netdev - Re: [PATCH net] llc: verify mac len before reading mac header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231025160119.13d0a8c2@kernel.org>
Date: Wed, 25 Oct 2023 16:01:19 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Willem de Bruijn <willemdebruijn.kernel@...il.com>
Cc: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
 pabeni@...hat.com, Willem de Bruijn <willemb@...gle.com>,
 syzbot+a8c7be6dee0de1b669cc@...kaller.appspotmail.com
Subject: Re: [PATCH net] llc: verify mac len before reading mac header

On Tue, 24 Oct 2023 15:49:36 -0400 Willem de Bruijn wrote:
> @@ -153,6 +153,9 @@ int llc_sap_action_send_test_r(struct llc_sap *sap, struct sk_buff *skb)
>  	int rc = 1;
>  	u32 data_size;
>  
> +	if (skb->mac_len < ETH_HLEN)
> +		return 0;

I think this one may want 1 to indicate error, technically. No?