netdev - Re: [PATCH net] llc: verify mac len before reading mac header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAF=yD-JV031xfCDwb_=GG-i8+CR3OnQMCMTsMvWU0vwDtByB=w@mail.gmail.com>
Date: Wed, 25 Oct 2023 19:05:59 -0400
From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com, 
	pabeni@...hat.com, Willem de Bruijn <willemb@...gle.com>, 
	syzbot+a8c7be6dee0de1b669cc@...kaller.appspotmail.com
Subject: Re: [PATCH net] llc: verify mac len before reading mac header

On Wed, Oct 25, 2023 at 7:01 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Tue, 24 Oct 2023 15:49:36 -0400 Willem de Bruijn wrote:
> > @@ -153,6 +153,9 @@ int llc_sap_action_send_test_r(struct llc_sap *sap, struct sk_buff *skb)
> >       int rc = 1;
> >       u32 data_size;
> >
> > +     if (skb->mac_len < ETH_HLEN)
> > +             return 0;
>
> I think this one may want 1 to indicate error, technically. No?

Absolutely, thanks. For both tests.

Will send a v2, with that Fixes tag too.