lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <ZTqSGOAjB+SHc9CJ@nanopsycho> Date: Thu, 26 Oct 2023 18:21:44 +0200 From: Jiri Pirko <jiri@...nulli.us> To: Jakub Kicinski <kuba@...nel.org> Cc: Nikolay Aleksandrov <razor@...ckwall.org>, bpf@...r.kernel.org, netdev@...r.kernel.org, martin.lau@...ux.dev, ast@...nel.org, andrii@...nel.org, john.fastabend@...il.com, andrew@...n.ch, toke@...nel.org, toke@...hat.com, sdf@...gle.com, daniel@...earbox.net, idosch@...sch.org Subject: Re: [PATCH bpf-next v2] netkit: use netlink policy for mode and policy attributes validation Thu, Oct 26, 2023 at 05:43:51PM CEST, kuba@...nel.org wrote: >On Thu, 26 Oct 2023 18:16:59 +0300 Nikolay Aleksandrov wrote: >> static const struct nla_policy netkit_policy[IFLA_NETKIT_MAX + 1] = { >> [IFLA_NETKIT_PEER_INFO] = { .len = sizeof(struct ifinfomsg) }, >> - [IFLA_NETKIT_POLICY] = { .type = NLA_U32 }, >> - [IFLA_NETKIT_MODE] = { .type = NLA_U32 }, >> - [IFLA_NETKIT_PEER_POLICY] = { .type = NLA_U32 }, >> + [IFLA_NETKIT_POLICY] = NLA_POLICY_VALIDATE_FN(NLA_BINARY, >> + netkit_check_policy, >> + sizeof(u32)), >> + [IFLA_NETKIT_MODE] = NLA_POLICY_VALIDATE_FN(NLA_BINARY, >> + netkit_check_mode, >> + sizeof(u32)), >> + [IFLA_NETKIT_PEER_POLICY] = NLA_POLICY_VALIDATE_FN(NLA_BINARY, >> + netkit_check_policy, >> + sizeof(u32)), > >I vote to leave this code be. It's not perfect. But typing it as binary >is not getting us closer to perfection. Yeah :/
Powered by blists - more mailing lists