lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CADjXwjjSjw-GxtiBFT_o+mdQT5hSOTH9nDNvEQHV1z4cdqX07A@mail.gmail.com> Date: Thu, 26 Oct 2023 16:52:35 -0700 From: Coco Li <lixiaoyan@...gle.com> To: Jakub Kicinski <kuba@...nel.org> Cc: Eric Dumazet <edumazet@...gle.com>, Neal Cardwell <ncardwell@...gle.com>, Mubashir Adnan Qureshi <mubashirq@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Andrew Lunn <andrew@...n.ch>, Jonathan Corbet <corbet@....net>, David Ahern <dsahern@...nel.org>, Daniel Borkmann <daniel@...earbox.net>, netdev@...r.kernel.org, Chao Wu <wwchao@...gle.com>, Wei Wang <weiwan@...gle.com>, Pradeep Nemavat <pnemavat@...gle.com> Subject: Re: [PATCH v4 net-next 3/6] net-smnp: reorganize SNMP fast path variables On Thu, Oct 26, 2023 at 7:20 AM Jakub Kicinski <kuba@...nel.org> wrote: > > On Thu, 26 Oct 2023 08:19:56 +0000 Coco Li wrote: > > Subject: [PATCH v4 net-next 3/6] net-smnp: reorganize SNMP fast path variables > > s/smnp/snmp/ > > > names of the metrics. User space binaries not ignoreing the > > ignoring > > > +/* Enums in this file are exported by their name and by > > + * their values. User space binaries should ingest both > > + * of the above, and therefore ordering changes in this > > + * file does not break user space. For an example, please > > + * see the output of /proc/net/netstat. > > I don't understand, what does it mean to be exposed by value? > User space uses the enum to offset into something or not? > If not why don't we move the enum out of uAPI entirely? > I mostly meant that i.e. cat /proc/net/netstat will export enum names first, and that userspace binary should consume both the name and the value. I have no objections to moving the enums outside, but that seems a bit tangential to the purpose of this patch series. > > + /* Caacheline organization can be found documented in > > Cacheline > > Please invest (your time) a spell check :S Much apologies, will run through spell checkers in the future.
Powered by blists - more mailing lists