netdev - Re: [PATCH v4 net-next 3/6] net-smnp: reorganize SNMP fast path variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231026182315.227fcd89@kernel.org>
Date: Thu, 26 Oct 2023 18:23:15 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Coco Li <lixiaoyan@...gle.com>
Cc: Eric Dumazet <edumazet@...gle.com>, Neal Cardwell
 <ncardwell@...gle.com>, Mubashir Adnan Qureshi <mubashirq@...gle.com>,
 Paolo Abeni <pabeni@...hat.com>, Andrew Lunn <andrew@...n.ch>, Jonathan
 Corbet <corbet@....net>, David Ahern <dsahern@...nel.org>, Daniel Borkmann
 <daniel@...earbox.net>, netdev@...r.kernel.org, Chao Wu
 <wwchao@...gle.com>, Wei Wang <weiwan@...gle.com>, Pradeep Nemavat
 <pnemavat@...gle.com>
Subject: Re: [PATCH v4 net-next 3/6] net-smnp: reorganize SNMP fast path
 variables

On Thu, 26 Oct 2023 16:52:35 -0700 Coco Li wrote:
> I have no objections to moving the enums outside, but that seems a bit
> tangential to the purpose of this patch series.

My thinking is - we assume we can reshuffle this enum, because nobody
uses the enum values directly. If someone does, tho, we would be
breaking binary compatibility.

Moving it out of include/uapi/ would break the build for anyone trying
to refer to the enum, That gives us quicker signal that we may have
broken someone's code.