netdev - Re: [PATCH net] net: sched: fix warn on htb offloaded class creation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sun, 29 Oct 2023 14:01:54 +0200
From: Gal Pressman <gal@...dia.com>
To: Maxim Mikityanskiy <maxtram95@...il.com>, Paolo Abeni <pabeni@...hat.com>
Cc: netdev@...r.kernel.org, Jamal Hadi Salim <jhs@...atatu.com>,
 Cong Wang <xiyou.wangcong@...il.com>, Jiri Pirko <jiri@...nulli.us>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Tariq Toukan <tariqt@...dia.com>,
 Saeed Mahameed <saeedm@...dia.com>
Subject: Re: [PATCH net] net: sched: fix warn on htb offloaded class creation

Hey Maxim!

On 27/10/2023 16:57, Maxim Mikityanskiy wrote:
> I believe this is not the right fix.
> 
> On Thu, 26 Oct 2023 at 17:36:48 +0200, Paolo Abeni wrote:
>> The following commands:
>>
>> tc qdisc add dev eth1 handle 2: root htb offload
>> tc class add dev eth1 parent 2: classid 2:1 htb rate 5mbit burst 15k
>>
>> yeld to a WARN in the HTB qdisc:
> 
> Something is off here. These are literally the most basic commands one
> could invoke with HTB offload, I'm sure they worked. Is it something
> that broke recently? Tariq/Gal/Saeed, could you check them on a Mellanox
> NIC?

This is working on our NICs, we do not hit that warning.