lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <202310291919.kni6w2ii-lkp@intel.com> Date: Sun, 29 Oct 2023 20:11:20 +0800 From: kernel test robot <lkp@...el.com> To: Coco Li <lixiaoyan@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Eric Dumazet <edumazet@...gle.com>, Neal Cardwell <ncardwell@...gle.com>, Mubashir Adnan Qureshi <mubashirq@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Andrew Lunn <andrew@...n.ch>, Jonathan Corbet <corbet@....net>, David Ahern <dsahern@...nel.org>, Daniel Borkmann <daniel@...earbox.net> Cc: oe-kbuild-all@...ts.linux.dev, netdev@...r.kernel.org, Chao Wu <wwchao@...gle.com>, Wei Wang <weiwan@...gle.com>, Pradeep Nemavat <pnemavat@...gle.com>, Coco Li <lixiaoyan@...gle.com> Subject: Re: [PATCH v5 net-next 3/5] netns-ipv4: reorganize netns_ipv4 fast path variables Hi Coco, kernel test robot noticed the following build warnings: [auto build test WARNING on net-next/main] url: https://github.com/intel-lab-lkp/linux/commits/Coco-Li/Documentations-Analyze-heavily-used-Networking-related-structs/20231029-172902 base: net-next/main patch link: https://lore.kernel.org/r/20231029075244.2612089-4-lixiaoyan%40google.com patch subject: [PATCH v5 net-next 3/5] netns-ipv4: reorganize netns_ipv4 fast path variables config: riscv-randconfig-002-20231029 (https://download.01.org/0day-ci/archive/20231029/202310291919.kni6w2ii-lkp@intel.com/config) compiler: riscv64-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231029/202310291919.kni6w2ii-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@...el.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202310291919.kni6w2ii-lkp@intel.com/ All warnings (new ones prefixed by >>): net/core/net_namespace.c: In function 'netns_ipv4_struct_check': net/core/net_namespace.c:1127:9: error: expected expression before '/' token 1127 | / TXRX readonly hotpath cache lines */ | ^ net/core/net_namespace.c: At top level: >> net/core/net_namespace.c:1102:20: warning: 'netns_ipv4_struct_check' defined but not used [-Wunused-function] 1102 | static void __init netns_ipv4_struct_check(void) | ^~~~~~~~~~~~~~~~~~~~~~~ vim +/netns_ipv4_struct_check +1102 net/core/net_namespace.c 1101 > 1102 static void __init netns_ipv4_struct_check(void) 1103 { 1104 /* TX readonly hotpath cache lines */ 1105 CACHELINE_ASSERT_GROUP_MEMBER(struct netns_ipv4, netns_ipv4_read_tx, 1106 sysctl_tcp_early_retrans); 1107 CACHELINE_ASSERT_GROUP_MEMBER(struct netns_ipv4, netns_ipv4_read_tx, 1108 sysctl_tcp_tso_win_divisor); 1109 CACHELINE_ASSERT_GROUP_MEMBER(struct netns_ipv4, netns_ipv4_read_tx, 1110 sysctl_tcp_tso_rtt_log); 1111 CACHELINE_ASSERT_GROUP_MEMBER(struct netns_ipv4, netns_ipv4_read_tx, 1112 sysctl_tcp_autocorking); 1113 CACHELINE_ASSERT_GROUP_MEMBER(struct netns_ipv4, netns_ipv4_read_tx, 1114 sysctl_tcp_min_snd_mss); 1115 CACHELINE_ASSERT_GROUP_MEMBER(struct netns_ipv4, netns_ipv4_read_tx, 1116 sysctl_tcp_notsent_lowat); 1117 CACHELINE_ASSERT_GROUP_MEMBER(struct netns_ipv4, netns_ipv4_read_tx, 1118 sysctl_tcp_limit_output_bytes); 1119 CACHELINE_ASSERT_GROUP_MEMBER(struct netns_ipv4, netns_ipv4_read_tx, 1120 sysctl_tcp_min_rtt_wlen); 1121 CACHELINE_ASSERT_GROUP_MEMBER(struct netns_ipv4, netns_ipv4_read_tx, 1122 sysctl_tcp_wmem); 1123 CACHELINE_ASSERT_GROUP_MEMBER(struct netns_ipv4, netns_ipv4_read_tx, 1124 sysctl_ip_fwd_use_pmtu); 1125 CACHELINE_ASSERT_GROUP_SIZE(struct netns_ipv4, netns_ipv4_read_tx, 33); 1126 > 1127 / TXRX readonly hotpath cache lines */ 1128 CACHELINE_ASSERT_GROUP_MEMBER(struct netns_ipv4, netns_ipv4_read_txrx, 1129 sysctl_tcp_moderate_rcvbuf); 1130 CACHELINE_ASSERT_GROUP_SIZE(struct netns_ipv4, netns_ipv4_read_txrx, 1); 1131 1132 /* RX readonly hotpath cache line */ 1133 CACHELINE_ASSERT_GROUP_MEMBER(struct netns_ipv4, netns_ipv4_read_rx, 1134 sysctl_ip_early_demux); 1135 CACHELINE_ASSERT_GROUP_MEMBER(struct netns_ipv4, netns_ipv4_read_rx, 1136 sysctl_tcp_early_demux); 1137 CACHELINE_ASSERT_GROUP_MEMBER(struct netns_ipv4, netns_ipv4_read_rx, 1138 sysctl_tcp_reordering); 1139 CACHELINE_ASSERT_GROUP_MEMBER(struct netns_ipv4, netns_ipv4_read_rx, 1140 sysctl_tcp_rmem); 1141 CACHELINE_ASSERT_GROUP_SIZE(struct netns_ipv4, netns_ipv4_read_rx, 18); 1142 } 1143 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists