netdev - Re: [PATCH v2 04/12] dt-bindings: net: starfive,jh7110-dwmac: Add JH7100 SoC compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 30 Oct 2023 08:29:58 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Rob Herring <robh@...nel.org>,
 Cristian Ciocaltea <cristian.ciocaltea@...labora.com>
Cc: Alexandre Torgue <alexandre.torgue@...s.st.com>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 linux-riscv@...ts.infradead.org, Eric Dumazet <edumazet@...gle.com>,
 Richard Cochran <richardcochran@...il.com>, Paolo Abeni <pabeni@...hat.com>,
 Jakub Kicinski <kuba@...nel.org>, Emil Renner Berthing <kernel@...il.dk>,
 Jose Abreu <joabreu@...opsys.com>, Conor Dooley <conor+dt@...nel.org>,
 Palmer Dabbelt <palmer@...belt.com>,
 linux-stm32@...md-mailman.stormreply.com, linux-kernel@...r.kernel.org,
 Paul Walmsley <paul.walmsley@...ive.com>,
 Samin Guo <samin.guo@...rfivetech.com>, netdev@...r.kernel.org,
 Albert Ou <aou@...s.berkeley.edu>, kernel@...labora.com,
 "David S. Miller" <davem@...emloft.net>,
 Maxime Coquelin <mcoquelin.stm32@...il.com>,
 linux-arm-kernel@...ts.infradead.org,
 Giuseppe Cavallaro <peppe.cavallaro@...com>, devicetree@...r.kernel.org,
 Rob Herring <robh+dt@...nel.org>
Subject: Re: [PATCH v2 04/12] dt-bindings: net: starfive,jh7110-dwmac: Add
 JH7100 SoC compatible

On 30/10/2023 02:37, Rob Herring wrote:
> 
> On Sun, 29 Oct 2023 06:27:04 +0200, Cristian Ciocaltea wrote:
>> The Synopsys DesignWare MAC found on StarFive JH7100 SoC is quite
>> similar to the newer JH7110, but it requires only two interrupts and a
>> single reset line.
>>
>> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@...labora.com>
>> ---
>>  .../devicetree/bindings/net/snps,dwmac.yaml   |  1 +
>>  .../bindings/net/starfive,jh7110-dwmac.yaml   | 74 +++++++++++++------
>>  2 files changed, 54 insertions(+), 21 deletions(-)
>>
> 
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/amlogic,meson-dwmac.example.dtb: ethernet@...10000: compatible: 'oneOf' conditional failed, one must be fixed:
> 	'starfive,jh7100-dwmac' was expected
> 	'amlogic,meson-gxbb-dwmac' is not one of ['starfive,jh7110-dwmac']
> 	'snps,dwmac-5.20' was expected
> 	from schema $id: http://devicetree.org/schemas/net/starfive,jh7110-dwmac.yaml#

And here you have proof of missing testing of patch #2.

Best regards,
Krzysztof