lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20231102155703.2itwweekjr7uqbsg@skbuf> Date: Thu, 2 Nov 2023 17:57:03 +0200 From: Vladimir Oltean <olteanv@...il.com> To: Linus Walleij <linus.walleij@...aro.org> Cc: Luiz Angelo Daros de Luca <luizluca@...il.com>, netdev@...r.kernel.org, alsi@...g-olufsen.dk, andrew@...n.ch, vivien.didelot@...il.com, f.fainelli@...il.com, davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com, robh+dt@...nel.org, krzk+dt@...nel.org, arinc.unal@...nc9.com Subject: Re: [PATCH net-next v2 3/3] net: dsa: realtek: support reset controller On Thu, Nov 02, 2023 at 05:55:21PM +0200, Vladimir Oltean wrote: > diff --git a/drivers/net/dsa/realtek/Kconfig b/drivers/net/dsa/realtek/Kconfig > index 060165a85fb7..857a039fb0f1 100644 > --- a/drivers/net/dsa/realtek/Kconfig > +++ b/drivers/net/dsa/realtek/Kconfig > @@ -15,39 +15,37 @@ menuconfig NET_DSA_REALTEK > > if NET_DSA_REALTEK > > +config NET_DSA_REALTEK_INTERFACE > + tristate > + help > + Common interface driver for accessing Realtek switches, either > + through MDIO or SMI. > + > config NET_DSA_REALTEK_MDIO > - tristate "Realtek MDIO interface driver" > - depends on OF > - depends on NET_DSA_REALTEK_RTL8365MB || NET_DSA_REALTEK_RTL8366RB > - depends on NET_DSA_REALTEK_RTL8365MB || !NET_DSA_REALTEK_RTL8365MB > - depends on NET_DSA_REALTEK_RTL8366RB || !NET_DSA_REALTEK_RTL8366RB > + tristate "Realtek MDIO interface support" I meant to also make "config NET_DSA_REALTEK_MDIO" a bool and not tristate. > help > Select to enable support for registering switches configured > through MDIO. > > config NET_DSA_REALTEK_SMI > - tristate "Realtek SMI interface driver" > - depends on OF > - depends on NET_DSA_REALTEK_RTL8365MB || NET_DSA_REALTEK_RTL8366RB > - depends on NET_DSA_REALTEK_RTL8365MB || !NET_DSA_REALTEK_RTL8365MB > - depends on NET_DSA_REALTEK_RTL8366RB || !NET_DSA_REALTEK_RTL8366RB > + bool "Realtek SMI interface support" > help > Select to enable support for registering switches connected > through SMI. > > config NET_DSA_REALTEK_RTL8365MB > tristate "Realtek RTL8365MB switch subdriver" > - imply NET_DSA_REALTEK_SMI > - imply NET_DSA_REALTEK_MDIO > + select NET_DSA_REALTEK_INTERFACE > select NET_DSA_TAG_RTL8_4 > + depends on OF > help > Select to enable support for Realtek RTL8365MB-VC and RTL8367S. > > config NET_DSA_REALTEK_RTL8366RB > tristate "Realtek RTL8366RB switch subdriver" > - imply NET_DSA_REALTEK_SMI > - imply NET_DSA_REALTEK_MDIO > + select NET_DSA_REALTEK_INTERFACE > select NET_DSA_TAG_RTL4_A > + depends on OF > help > Select to enable support for Realtek RTL8366RB.
Powered by blists - more mailing lists