netdev - Re: [PATCH net-next v2 3/3] net: dsa: realtek: support reset controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231102162132.ksfv5ba3kc2efc63@skbuf>
Date: Thu, 2 Nov 2023 18:21:32 +0200
From: Vladimir Oltean <olteanv@...il.com>
To: Linus Walleij <linus.walleij@...aro.org>
Cc: Luiz Angelo Daros de Luca <luizluca@...il.com>, netdev@...r.kernel.org,
	alsi@...g-olufsen.dk, andrew@...n.ch, vivien.didelot@...il.com,
	f.fainelli@...il.com, davem@...emloft.net, kuba@...nel.org,
	pabeni@...hat.com, robh+dt@...nel.org, krzk+dt@...nel.org,
	arinc.unal@...nc9.com
Subject: Re: [PATCH net-next v2 3/3] net: dsa: realtek: support reset
 controller

On Thu, Nov 02, 2023 at 05:55:21PM +0200, Vladimir Oltean wrote:
> +static int __init realtek_interface_init(void)
> +{
> +	int err;
> +
> +	err = realtek_mdio_init();
> +	if (err)
> +		return err;
> +
> +	err = realtek_smi_init();
> +	if (err) {
> +		realtek_smi_exit();

One more correction, this was supposed to be realtek_mdio_exit().

> +		return err;
> +	}
> +
> +	return 0;
> +}
> +module_init(realtek_interface_init);