lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <72b57457-43e1-49f7-9670-08bbf03231e1@linux.ibm.com> Date: Thu, 2 Nov 2023 11:34:36 +0100 From: Wenjia Zhang <wenjia@...ux.ibm.com> To: "D. Wythe" <alibuda@...ux.alibaba.com>, kgraul@...ux.ibm.com, jaka@...ux.ibm.com, wintera@...ux.ibm.com Cc: kuba@...nel.org, davem@...emloft.net, netdev@...r.kernel.org, linux-s390@...r.kernel.org, linux-rdma@...r.kernel.org Subject: Re: [PATCH net v1 1/3] net/smc: fix dangling sock under state SMC_APPFINCLOSEWAIT On 02.11.23 06:52, D. Wythe wrote: > From: "D. Wythe" <alibuda@...ux.alibaba.com> > > Considering scenario: > > smc_cdc_rx_handler > __smc_release > sock_set_flag > smc_close_active() > sock_set_flag > > __set_bit(DEAD) __set_bit(DONE) > > Dues to __set_bit is not atomic, the DEAD or DONE might be lost. > if the DEAD flag lost, the state SMC_CLOSED will be never be reached > in smc_close_passive_work: > > if (sock_flag(sk, SOCK_DEAD) && > smc_close_sent_any_close(conn)) { > sk->sk_state = SMC_CLOSED; > } else { > /* just shutdown, but not yet closed locally */ > sk->sk_state = SMC_APPFINCLOSEWAIT; > } > > Replace sock_set_flags or __set_bit to set_bit will fix this problem. > Since set_bit is atomic. > > Signed-off-by: D. Wythe <alibuda@...ux.alibaba.com> > Reviewed-by: Dust Li <dust.li@...ux.alibaba.com> Fixes tag?
Powered by blists - more mailing lists