lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20231102103537.247336-1-bjorn@kernel.org> Date: Thu, 2 Nov 2023 11:35:37 +0100 From: Björn Töpel <bjorn@...nel.org> To: Andrii Nakryiko <andrii@...nel.org>, Mykola Lysenko <mykolal@...com>, bpf@...r.kernel.org, Daniel Borkmann <daniel@...earbox.net>, netdev@...r.kernel.org Cc: Björn Töpel <bjorn@...osinc.com>, Alexei Starovoitov <ast@...nel.org>, linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org, Larysa Zaremba <larysa.zaremba@...el.com> Subject: [PATCH bpf] selftests/bpf: Fix broken build where char is unsigned From: Björn Töpel <bjorn@...osinc.com> There are architectures where char is not signed. If so, the following error is triggered: | xdp_hw_metadata.c:435:42: error: result of comparison of constant -1 \ | with expression of type 'char' is always true \ | [-Werror,-Wtautological-constant-out-of-range-compare] | 435 | while ((opt = getopt(argc, argv, "mh")) != -1) { | | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~ | 1 error generated. Correct by changing the char to int. Fixes: bb6a88885fde ("selftests/bpf: Add options and frags to xdp_hw_metadata") Signed-off-by: Björn Töpel <bjorn@...osinc.com> --- tools/testing/selftests/bpf/xdp_hw_metadata.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/bpf/xdp_hw_metadata.c b/tools/testing/selftests/bpf/xdp_hw_metadata.c index 17c0f92ff160..c3ba40d0b9de 100644 --- a/tools/testing/selftests/bpf/xdp_hw_metadata.c +++ b/tools/testing/selftests/bpf/xdp_hw_metadata.c @@ -430,7 +430,7 @@ static void print_usage(void) static void read_args(int argc, char *argv[]) { - char opt; + int opt; while ((opt = getopt(argc, argv, "mh")) != -1) { switch (opt) { base-commit: cb3c6a58be50c65014296aa3455cae0fa1e82eac -- 2.40.1
Powered by blists - more mailing lists