lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <ZUStrQCqBjBBB6dc@infradead.org> Date: Fri, 3 Nov 2023 01:22:05 -0700 From: Christoph Hellwig <hch@...radead.org> To: Nathan Chancellor <nathan@...nel.org> Cc: edumazet@...gle.com, davem@...emloft.net, dsahern@...nel.org, kuba@...nel.org, pabeni@...hat.com, ndesaulniers@...gle.com, trix@...hat.com, 0x7f454c46@...il.com, fruggeri@...sta.com, noureddine@...sta.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, llvm@...ts.linux.dev, patches@...ts.linux.dev Subject: Re: [PATCH net] tcp: Fix -Wc23-extensions in tcp_options_write() On Tue, Oct 31, 2023 at 01:23:35PM -0700, Nathan Chancellor wrote: > Clang warns (or errors with CONFIG_WERROR=y) when CONFIG_TCP_AO is set: > > net/ipv4/tcp_output.c:663:2: error: label at end of compound statement is a C23 extension [-Werror,-Wc23-extensions] > 663 | } > | ^ > 1 error generated. > > On earlier releases (such as clang-11, the current minimum supported > version for building the kernel) that do not support C23, this was a > hard error unconditionally: > > net/ipv4/tcp_output.c:663:2: error: expected statement > } > ^ > 1 error generated. > > Add a semicolon after the label to create an empty statement, which > resolves the warning or error for all compilers. Can you please just split the A0 handlig into a separate helper, which shuld make the whole thing a lot cleaner?
Powered by blists - more mailing lists