[<prev] [next>] [day] [month] [year] [list]
Message-ID: <eb621845-45f8-4822-b92a-365d485f6870@siemens.com>
Date: Fri, 3 Nov 2023 10:13:37 +0100
From: Jan Kiszka <jan.kiszka@...mens.com>
To: "David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>, MD Danish Anwar <danishanwar@...com>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
"Lopes Ivo, Diogo Miguel (T CED IFD-PT)" <diogo.ivo@...mens.com>,
Nishanth Menon <nm@...com>,
"Su, Bao Cheng (RC-CN DF FA R&D)" <baocheng.su@...mens.com>
Subject: [PATCH] net: ti: icssg-prueth: Fix error cleanup on failing
pruss_request_mem_region
From: Jan Kiszka <jan.kiszka@...mens.com>
We were just continuing in this case, surely not desired.
Signed-off-by: Jan Kiszka <jan.kiszka@...mens.com>
---
drivers/net/ethernet/ti/icssg/icssg_prueth.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/ti/icssg/icssg_prueth.c b/drivers/net/ethernet/ti/icssg/icssg_prueth.c
index 0242e123fc05..70c696ef0177 100644
--- a/drivers/net/ethernet/ti/icssg/icssg_prueth.c
+++ b/drivers/net/ethernet/ti/icssg/icssg_prueth.c
@@ -2064,7 +2064,7 @@ static int prueth_probe(struct platform_device *pdev)
&prueth->shram);
if (ret) {
dev_err(dev, "unable to get PRUSS SHRD RAM2: %d\n", ret);
- pruss_put(prueth->pruss);
+ goto put_pruss;
}
prueth->sram_pool = of_gen_pool_get(np, "sram", 0);
@@ -2209,6 +2209,8 @@ static int prueth_probe(struct platform_device *pdev)
put_mem:
pruss_release_mem_region(prueth->pruss, &prueth->shram);
+
+put_pruss:
pruss_put(prueth->pruss);
put_cores:
--
2.35.3
Powered by blists - more mailing lists