netdev - Re: [PATCH net-next 4/6] ice: Add support for E830 DDP package segment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZUT50a94kk2pMGKb@boxer>
Date: Fri, 3 Nov 2023 14:46:57 +0100
From: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
To: Jacob Keller <jacob.e.keller@...el.com>
CC: <netdev@...r.kernel.org>, David Miller <davem@...emloft.net>, "Jakub
 Kicinski" <kuba@...nel.org>, Dan Nowlin <dan.nowlin@...el.com>, "Jesse
 Brandeburg" <jesse.brandeburg@...el.com>, Paul Greenwalt
	<paul.greenwalt@...el.com>, Simon Horman <horms@...nel.org>, Tony Brelinski
	<tony.brelinski@...el.com>
Subject: Re: [PATCH net-next 4/6] ice: Add support for E830 DDP package
 segment

On Wed, Oct 25, 2023 at 02:41:55PM -0700, Jacob Keller wrote:
> From: Dan Nowlin <dan.nowlin@...el.com>
> 
> Add support for E830 DDP package segment. For the E830 package,
> signature buffers will not be included inline in the configuration
> buffers. Instead, the signature buffers will be located in a
> signature segment.

This breaks E810 usage, they go into safe mode. I'll be sending a revert
to this commit or if you have any other idea how to address that I'm all
ears.

> 
> Reviewed-by: Jesse Brandeburg <jesse.brandeburg@...el.com>
> Signed-off-by: Dan Nowlin <dan.nowlin@...el.com>
> Co-developed-by: Paul Greenwalt <paul.greenwalt@...el.com>
> Signed-off-by: Paul Greenwalt <paul.greenwalt@...el.com>
> Reviewed-by: Simon Horman <horms@...nel.org>
> Tested-by: Tony Brelinski <tony.brelinski@...el.com>
> Signed-off-by: Jacob Keller <jacob.e.keller@...el.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_ddp.c  | 436 ++++++++++++++++++----
>  drivers/net/ethernet/intel/ice/ice_ddp.h  |  27 +-
>  drivers/net/ethernet/intel/ice/ice_type.h |   3 +
>  3 files changed, 387 insertions(+), 79 deletions(-)
>