netdev - Re: [PATCH net] net: xt_recent: fix (increase) ipv6 literal buffer length

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANP3RGdCQ6REeZV9hE2HjaAN0gMtT8nuBhwQ-CQxVPTD1=k_zg@mail.gmail.com>
Date: Sun, 5 Nov 2023 11:59:18 -0800
From: Maciej Żenczykowski <maze@...gle.com>
To: Jan Engelhardt <jengelh@...i.de>
Cc: "David S . Miller" <davem@...emloft.net>, Pablo Neira Ayuso <pablo@...filter.org>, 
	Florian Westphal <fw@...len.de>, 
	Linux Network Development Mailing List <netdev@...r.kernel.org>, 
	Netfilter Development Mailing List <netfilter-devel@...r.kernel.org>, Patrick McHardy <kaber@...sh.net>
Subject: Re: [PATCH net] net: xt_recent: fix (increase) ipv6 literal buffer length

On Sun, Nov 5, 2023 at 12:08 AM Jan Engelhardt <jengelh@...i.de> wrote:
>
>
> On Saturday 2023-11-04 22:00, Maciej Żenczykowski wrote:
> >
> >IPv4 in IPv6 is supported by in6_pton [...]
> >but the provided buffer is too short:
>
> If in6_pton were to support tunnel traffic.. wait that sounds
> unusual, and would require dst to be at least 20 bytes, which the
> function documentation contradicts.
>
> As the RFCs make no precise name proposition
>
>         (IPv6 Text Representation, third alternative,
>         IPv4 "decimal value" of the "four low-order 8-bit pieces")
>
> so let's just call it
>
>         "low-32-bit dot-decimal representation"
>
> which should avoid the tunnel term.

Resent [ https://patchwork.kernel.org/project/netdevbpf/patch/20231105195600.522779-1-maze@google.com/
], hopefully this is better.
Also:
- used your (Jan's) new email in the CC.
- changed net to netfilter in the commit title
(but as it is such a trivial bug fix, it does still feel like it
should go straight into net/main... rather than via netfilter repos)

Cheers,
Maciej