netdev - Re: net: bcmasp: Use common error handling code in bcmasp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dce77105-47ab-4ec7-8d46-b983c630dad8@web.de>
Date: Tue, 7 Nov 2023 07:38:01 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: Jakub Kicinski <kuba@...nel.org>,
 Wojciech Drewek <wojciech.drewek@...el.com>
Cc: Julia Lawall <Julia.Lawall@...ia.fr>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Florian Fainelli <florian.fainelli@...adcom.com>,
 Justin Chen <justin.chen@...adcom.com>, Paolo Abeni <pabeni@...hat.com>,
 bcm-kernel-feedback-list@...adcom.com, netdev@...r.kernel.org,
 kernel-janitors@...r.kernel.org, cocci@...ia.fr,
 LKML <linux-kernel@...r.kernel.org>, Simon Horman <horms@...nel.org>
Subject: Re: net: bcmasp: Use common error handling code in bcmasp_probe()

>> Add a jump target so that a bit of exception handling can be better
>> reused at the end of this function.
…
>> ---
>>  drivers/net/ethernet/broadcom/asp2/bcmasp.c | 10 ++++++----
>>  1 file changed, 6 insertions(+), 4 deletions(-)
>
> The diffstat proves otherwise.
> Please don't send such patches to networking.

How does this feedback fit to a change possibility which was reviewed by
Wojciech Drewek yesterday?

Regards,
Markus