netdev - Re: net: bcmasp: Use common error handling code in bcmasp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALSSxFYRgPwEq+QhCOYPqrtae8RvL=jTOcz4mk3vbe+Fc0QwbQ@mail.gmail.com>
Date: Tue, 7 Nov 2023 10:48:13 -0800
From: Justin Chen <justin.chen@...adcom.com>
To: Markus Elfring <Markus.Elfring@....de>
Cc: Jakub Kicinski <kuba@...nel.org>, Wojciech Drewek <wojciech.drewek@...el.com>, 
	Julia Lawall <Julia.Lawall@...ia.fr>, "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Florian Fainelli <florian.fainelli@...adcom.com>, 
	Paolo Abeni <pabeni@...hat.com>, bcm-kernel-feedback-list@...adcom.com, 
	netdev@...r.kernel.org, kernel-janitors@...r.kernel.org, cocci@...ia.fr, 
	LKML <linux-kernel@...r.kernel.org>, Simon Horman <horms@...nel.org>
Subject: Re: net: bcmasp: Use common error handling code in bcmasp_probe()

On Mon, Nov 6, 2023 at 10:38 PM Markus Elfring <Markus.Elfring@....de> wrote:
>
> >> Add a jump target so that a bit of exception handling can be better
> >> reused at the end of this function.
> …
> >> ---
> >>  drivers/net/ethernet/broadcom/asp2/bcmasp.c | 10 ++++++----
> >>  1 file changed, 6 insertions(+), 4 deletions(-)
> >
> > The diffstat proves otherwise.
> > Please don't send such patches to networking.
>
> How does this feedback fit to a change possibility which was reviewed by
> Wojciech Drewek yesterday?
>
> Regards,
> Markus

We are making the code harder to follow with these changes. Also
adding more lines than removing. Don't think this patch is an
improvement IMHO. NAK on my end.

Thanks,
Justin

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4206 bytes)