netdev - Re: [PATCH iwl-net v3] ice: fix DDP package download for packages without signature segment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231108185951.GE173253@kernel.org>
Date: Wed, 8 Nov 2023 13:59:51 -0500
From: Simon Horman <horms@...nel.org>
To: Paul Greenwalt <paul.greenwalt@...el.com>
Cc: intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org,
	jesse.brandeburg@...el.com, anthony.l.nguyen@...el.com,
	davem@...emloft.net, kuba@...nel.org, tony.brelinski@...el.com,
	Dan Nowlin <dan.nowlin@...el.com>,
	Maciej Fijalkowski <maciej.fijalkowski@...el.com>,
	Wojciech Drewek <wojciech.drewek@...el.com>,
	Jacob Keller <jacob.e.keller@...el.com>
Subject: Re: [PATCH iwl-net v3] ice: fix DDP package download for packages
 without signature segment

On Tue, Nov 07, 2023 at 12:32:27PM -0500, Paul Greenwalt wrote:
> From: Dan Nowlin <dan.nowlin@...el.com>
> 
> Commit 3cbdb0343022 ("ice: Add support for E830 DDP package segment")
> incorrectly removed support for package download for packages without a
> signature segment. These packages include the signature buffer inline
> in the configurations buffers, and not in a signature segment.
> 
> Fix package download by providing download support for both packages
> with (ice_download_pkg_with_sig_seg()) and without signature segment
> (ice_download_pkg_without_sig_seg()).
> 
> Fixes: 3cbdb0343022 ("ice: Add support for E830 DDP package segment")
> Reported-by: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
> Closes: https://lore.kernel.org/netdev/ZUT50a94kk2pMGKb@boxer/
> Tested-by: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
> Reviewed-by: Wojciech Drewek <wojciech.drewek@...el.com>
> Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>
> Signed-off-by: Dan Nowlin <dan.nowlin@...el.com>
> Signed-off-by: Paul Greenwalt <paul.greenwalt@...el.com>

Reviewed-by: Simon Horman <horms@...nel.org>