netdev - RE: [Intel-wired-lan] [PATCH iwl-net v3] ice: fix DDP package download for packages without signature segment

Open Source and information security mailing list archives

Message-ID: <BN9PR11MB5354BE41B278F3CA1E9FB35B80AEA@BN9PR11MB5354.namprd11.prod.outlook.com>
Date: Fri, 10 Nov 2023 09:30:48 +0000
From: "Arland, ArpanaX" <arpanax.arland@...el.com>
To: "Greenwalt, Paul" <paul.greenwalt@...el.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC: "Nowlin, Dan" <dan.nowlin@...el.com>, "Fijalkowski, Maciej"
	<maciej.fijalkowski@...el.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "Brandeburg, Jesse" <jesse.brandeburg@...el.com>,
	"Keller, Jacob E" <jacob.e.keller@...el.com>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>, "Greenwalt, Paul" <paul.greenwalt@...el.com>,
	"horms@...nel.org" <horms@...nel.org>, "Drewek, Wojciech"
	<wojciech.drewek@...el.com>, "kuba@...nel.org" <kuba@...nel.org>,
	"davem@...emloft.net" <davem@...emloft.net>
Subject: RE: [Intel-wired-lan] [PATCH iwl-net v3] ice: fix DDP package
 download for packages without signature segment

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of Paul Greenwalt
> Sent: Tuesday, November 7, 2023 11:02 PM
> To: intel-wired-lan@...ts.osuosl.org
> Cc: Nowlin, Dan <dan.nowlin@...el.com>; Fijalkowski, Maciej <maciej.fijalkowski@...el.com>; netdev@...r.kernel.org; Brandeburg, Jesse <jesse.brandeburg@...el.com>; Keller, Jacob E <jacob.e.keller@...el.com>; Nguyen, Anthony L <anthony.l.nguyen@...el.com>; Greenwalt, Paul <paul.greenwalt@...el.com>; horms@...nel.org; Drewek, Wojciech <wojciech.drewek@...el.com>; kuba@...nel.org; davem@...emloft.net
> Subject: [Intel-wired-lan] [PATCH iwl-net v3] ice: fix DDP package download for packages without signature segment
>
> From: Dan Nowlin <dan.nowlin@...el.com>
>
> Commit 3cbdb0343022 ("ice: Add support for E830 DDP package segment") incorrectly removed support for package download for packages without a signature segment. These packages include the signature buffer inline in the configurations buffers, and not in a signature segment.
>
> Fix package download by providing download support for both packages with (ice_download_pkg_with_sig_seg()) and without signature segment (ice_download_pkg_without_sig_seg()).
>
> Fixes: 3cbdb0343022 ("ice: Add support for E830 DDP package segment")
> Reported-by: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
> Closes: https://lore.kernel.org/netdev/ZUT50a94kk2pMGKb@boxer/
> Tested-by: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
> Reviewed-by: Wojciech Drewek <wojciech.drewek@...el.com>
> Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>
> Signed-off-by: Dan Nowlin <dan.nowlin@...el.com>
> Signed-off-by: Paul Greenwalt <paul.greenwalt@...el.com>
> ---
> Changelog
> v2->v3:
> - correct Changelog version tag, add Closes, Tested-by and Reviewed-by.
>   Remove unnecessary local variable initialization in ice_dwnld_cfg_bufs(),
>   and unnecessary local variable in ice_download_pkg_without_sig_seg(),
> v1->v2:
> - correct Reported-by email address.
> ---
>  drivers/net/ethernet/intel/ice/ice_ddp.c | 103 ++++++++++++++++++++++-
>  1 file changed, 100 insertions(+), 3 deletions(-)
>

Tested-by: Arpana Arland <arpanax.arland@...el.com> (A Contingent worker at Intel)
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@...osl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives