netdev - Re: [PATCH net-next 04/15] net: page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 9 Nov 2023 18:48:39 +0200
From: Ilias Apalodimas <ilias.apalodimas@...aro.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com, 
	pabeni@...hat.com, almasrymina@...gle.com, hawk@...nel.org
Subject: Re: [PATCH net-next 04/15] net: page_pool: id the page pools

On Thu, 9 Nov 2023 at 18:22, Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Thu, 9 Nov 2023 11:21:32 +0200 Ilias Apalodimas wrote:
> > > +       mutex_lock(&page_pools_lock);
> > > +       err = xa_alloc_cyclic(&page_pools, &pool->user.id, pool, xa_limit_32b,
> > > +                             &id_alloc_next, GFP_KERNEL);
> > > +       if (err < 0)
> > > +               goto err_unlock;
> >
> > A nit really, but get rid of the if/goto and just let this return err; ?
>
> There's more stuff added here by a subsequent patch. It ends up like
> this:
>
> int page_pool_list(struct page_pool *pool)
> {
>         static u32 id_alloc_next;
>         int err;
>
>         mutex_lock(&page_pools_lock);
>         err = xa_alloc_cyclic(&page_pools, &pool->user.id, pool, xa_limit_32b,
>                               &id_alloc_next, GFP_KERNEL);
>         if (err < 0)
>                 goto err_unlock;
>
>         if (pool->slow.netdev) {
>                 hlist_add_head(&pool->user.list,
>                                &pool->slow.netdev->page_pools);
>                 pool->user.napi_id = pool->p.napi ? pool->p.napi->napi_id : 0;
>
>                 netdev_nl_page_pool_event(pool, NETDEV_CMD_PAGE_POOL_ADD_NTF);
>         }
>
>         mutex_unlock(&page_pools_lock);
>         return 0;
>
> err_unlock:
>         mutex_unlock(&page_pools_lock);
>         return err;
> }
>
> Do you want me to combine the error and non-error paths?
> I have a weak preference for not mixing, sometimes err gets set
> to a positive value and that starts to propagate, unlikely to
> happen here tho.

Nop that's fine -- I actually prefer it myself. I just haven't got the
follow up patches yet


Reviewed-by: Ilias Apalodimas <ilias.apalodimas@...aro.org>