netdev - Re: [PATCH net-next 07/15] eth: link netdev to page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAC_iWjKRUi8qxGeDFzhdBO=xn8ngnjO9j7Q5Mnbdg+rSBxuDYg@mail.gmail.com>
Date: Thu, 9 Nov 2023 18:51:13 +0200
From: Ilias Apalodimas <ilias.apalodimas@...aro.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com, 
	pabeni@...hat.com, almasrymina@...gle.com, hawk@...nel.org
Subject: Re: [PATCH net-next 07/15] eth: link netdev to page_pools in drivers

On Thu, 9 Nov 2023 at 18:26, Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Thu, 9 Nov 2023 11:11:04 +0200 Ilias Apalodimas wrote:
> > > ---
> > >  drivers/net/ethernet/broadcom/bnxt/bnxt.c         | 1 +
> > >  drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 1 +
> > >  drivers/net/ethernet/microsoft/mana/mana_en.c     | 1 +
> > >  3 files changed, 3 insertions(+)
> >
> > Mind add a line for netsec.c (probably in netsec_setup_rx_dring),
> > since that's the only NIC I currently have around with pp support?
>
> It's a single queue / single napi device? So like this?

Yes it is

>
> diff --git a/drivers/net/ethernet/socionext/netsec.c b/drivers/net/ethernet/socionext/netsec.c
> index 0891e9e49ecb..384c506bb930 100644
> --- a/drivers/net/ethernet/socionext/netsec.c
> +++ b/drivers/net/ethernet/socionext/netsec.c
> @@ -1302,6 +1302,8 @@ static int netsec_setup_rx_dring(struct netsec_priv *priv)
>                 .dma_dir = xdp_prog ? DMA_BIDIRECTIONAL : DMA_FROM_DEVICE,
>                 .offset = NETSEC_RXBUF_HEADROOM,
>                 .max_len = NETSEC_RX_BUF_SIZE,
> +               .napi = priv->napi,
> +               .netdev = priv->ndev,

Yea

Thanks
/Ilias
>         };
>         int i, err;
>