netdev - Re: [PATCH net] ptp: annotate data-race around q->head and q->tail

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZVAf_qdRfDAQYUt-@hoboy.vegasvil.org>
Date: Sat, 11 Nov 2023 16:44:46 -0800
From: Richard Cochran <richardcochran@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Eric Dumazet <edumazet@...gle.com>,
	"David S . Miller" <davem@...emloft.net>,
	Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
	eric.dumazet@...il.com
Subject: Re: [PATCH net] ptp: annotate data-race around q->head and q->tail

On Fri, Nov 10, 2023 at 11:52:24AM -0800, Jakub Kicinski wrote:

> Meaning we should revert 8a4f030dbced ("ptp: Fixes a null pointer
> dereference in ptp_ioctl") ?

Yes, I think that would be ideal.

The test itself is harmless, but keeping it will make people think, "oh
this pointer can be invalid."

In fact the core stack ensures that ioctl() can't be invoked after
release(), otherwise Bad Stuff happens.

Thanks,
Richard