netdev - Re: [PATCH 12/22] csky: fix arch_jump_label_transform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sat, 11 Nov 2023 23:21:53 -0500
From: Guo Ren <guoren@...nel.org>
To: Arnd Bergmann <arnd@...nel.org>
Cc: Andrew Morton <akpm@...ux-foundation.org>, linux-kernel@...r.kernel.org, 
	Masahiro Yamada <masahiroy@...nel.org>, linux-kbuild@...r.kernel.org, 
	Arnd Bergmann <arnd@...db.de>, Matt Turner <mattst88@...il.com>, Vineet Gupta <vgupta@...nel.org>, 
	Russell King <linux@...linux.org.uk>, Catalin Marinas <catalin.marinas@....com>, 
	Will Deacon <will@...nel.org>, Steven Rostedt <rostedt@...dmis.org>, 
	Masami Hiramatsu <mhiramat@...nel.org>, Mark Rutland <mark.rutland@....com>, 
	Peter Zijlstra <peterz@...radead.org>, Ard Biesheuvel <ardb@...nel.org>, 
	Huacai Chen <chenhuacai@...nel.org>, Greg Ungerer <gerg@...ux-m68k.org>, 
	Michal Simek <monstr@...str.eu>, Thomas Bogendoerfer <tsbogend@...ha.franken.de>, 
	Dinh Nguyen <dinguyen@...nel.org>, Michael Ellerman <mpe@...erman.id.au>, 
	Nicholas Piggin <npiggin@...il.com>, Christophe Leroy <christophe.leroy@...roup.eu>, 
	Geoff Levand <geoff@...radead.org>, Palmer Dabbelt <palmer@...belt.com>, 
	Heiko Carstens <hca@...ux.ibm.com>, 
	John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>, "David S. Miller" <davem@...emloft.net>, 
	Andy Lutomirski <luto@...nel.org>, Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>, 
	x86@...nel.org, Helge Deller <deller@....de>, 
	Sudip Mukherjee <sudipm.mukherjee@...il.com>, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Timur Tabi <timur@...nel.org>, 
	Kent Overstreet <kent.overstreet@...ux.dev>, David Woodhouse <dwmw2@...radead.org>, 
	"Naveen N. Rao" <naveen.n.rao@...ux.ibm.com>, 
	Anil S Keshavamurthy <anil.s.keshavamurthy@...el.com>, Kees Cook <keescook@...omium.org>, 
	Vincenzo Frascino <vincenzo.frascino@....com>, Juri Lelli <juri.lelli@...hat.com>, 
	Vincent Guittot <vincent.guittot@...aro.org>, Nathan Chancellor <nathan@...nel.org>, 
	Nick Desaulniers <ndesaulniers@...gle.com>, Nicolas Schier <nicolas@...sle.eu>, 
	Al Viro <viro@...iv.linux.org.uk>, 
	Uwe Kleine-König <u.kleine-koenig@...gutronix.de>, 
	linux-alpha@...r.kernel.org, linux-snps-arc@...ts.infradead.org, 
	linux-arm-kernel@...ts.infradead.org, linux-trace-kernel@...r.kernel.org, 
	linux-csky@...r.kernel.org, loongarch@...ts.linux.dev, 
	linux-m68k@...ts.linux-m68k.org, linux-mips@...r.kernel.org, 
	linuxppc-dev@...ts.ozlabs.org, linux-riscv@...ts.infradead.org, 
	linux-s390@...r.kernel.org, linux-sh@...r.kernel.org, 
	sparclinux@...r.kernel.org, netdev@...r.kernel.org, 
	linux-parisc@...r.kernel.org, linux-usb@...r.kernel.org, 
	linux-fbdev@...r.kernel.org, dri-devel@...ts.freedesktop.org, 
	linux-bcachefs@...r.kernel.org, linux-mtd@...ts.infradead.org
Subject: Re: [PATCH 12/22] csky: fix arch_jump_label_transform_static override

On Wed, Nov 8, 2023 at 8:02 AM Arnd Bergmann <arnd@...nel.org> wrote:
>
> From: Arnd Bergmann <arnd@...db.de>
>
> The arch_jump_label_transform_static() function in csky was originally meant to
> override the generic __weak function, but that got changed to an #ifndef check.
>
> This showed up as a missing-prototype warning:
> arch/csky/kernel/jump_label.c:43:6: error: no previous prototype for 'arch_jump_label_transform_static' [-Werror=missing-prototypes]
>
> Change the method to use the new method of having a #define and a prototype
> for the global function.
>
> Fixes: 7e6b9db27de9 ("jump_label: make initial NOP patching the special case")
> Fixes: 4e8bb4ba5a55 ("csky: Add jump-label implementation")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  arch/csky/include/asm/jump_label.h | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/arch/csky/include/asm/jump_label.h b/arch/csky/include/asm/jump_label.h
> index d488ba6084bc..98a3f4b168bd 100644
> --- a/arch/csky/include/asm/jump_label.h
> +++ b/arch/csky/include/asm/jump_label.h
> @@ -43,5 +43,10 @@ static __always_inline bool arch_static_branch_jump(struct static_key *key,
>         return true;
>  }
>
> +enum jump_label_type;
> +void arch_jump_label_transform_static(struct jump_entry *entry,
> +                                     enum jump_label_type type);
> +#define arch_jump_label_transform_static arch_jump_label_transform_static
> +
>  #endif  /* __ASSEMBLY__ */
>  #endif /* __ASM_CSKY_JUMP_LABEL_H */
> --
> 2.39.2
>
>
Thank you!
Reviewed-by: Guo Ren <guoren@...nel.org>

-- 
Best Regards
 Guo Ren