[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20231113163029.106912-1-johnathanx.mantey@intel.com>
Date: Mon, 13 Nov 2023 08:30:29 -0800
From: Johnathan Mantey <johnathanx.mantey@...el.com>
To: <netdev@...r.kernel.org>
CC: <sam@...dozajonas.com>, <davem@...emloft.net>, <edumazet@...gle.com>,
<kuba@...nel.org>, <pabeni@...hat.com>, <linux-kernel@...r.kernel.org>
Subject: [PATCH net v3] Revert ncsi: Propagate carrier gain/loss events to the NCSI controller
This reverts commit 3780bb29311eccb7a1c9641032a112eed237f7e3.
The cited commit introduced unwanted behavior.
The intent for the commit was to be able to detect carrier loss/gain
for just the NIC connected to the BMC. The unwanted effect is a
carrier loss for auxiliary paths also causes the BMC to lose
carrier. The BMC never regains carrier despite the secondary NIC
regaining a link.
This change, when merged, needs to be backported to stable kernels.
5.4-stable, 5.10-stable, 5.15-stable, 6.1-stable, 6.5-stable
Fixes: 3780bb29311e ("ncsi: Propagate carrier gain/loss events to the NCSI controller")
CC: stable@...r.kernel.org
Signed-off-by: Johnathan Mantey <johnathanx.mantey@...el.com>
---
net/ncsi/ncsi-aen.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/net/ncsi/ncsi-aen.c b/net/ncsi/ncsi-aen.c
index f8854bff286c..62fb1031763d 100644
--- a/net/ncsi/ncsi-aen.c
+++ b/net/ncsi/ncsi-aen.c
@@ -89,11 +89,6 @@ static int ncsi_aen_handler_lsc(struct ncsi_dev_priv *ndp,
if ((had_link == has_link) || chained)
return 0;
- if (had_link)
- netif_carrier_off(ndp->ndev.dev);
- else
- netif_carrier_on(ndp->ndev.dev);
-
if (!ndp->multi_package && !nc->package->multi_channel) {
if (had_link) {
ndp->flags |= NCSI_DEV_RESHUFFLE;
--
2.41.0
Powered by blists - more mailing lists