lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 14 Nov 2023 19:46:16 +0000
From: Simon Horman <horms@...nel.org>
To: Johnathan Mantey <johnathanx.mantey@...el.com>
Cc: netdev@...r.kernel.org, sam@...dozajonas.com, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net v3] Revert ncsi: Propagate carrier gain/loss events
 to the NCSI controller

On Mon, Nov 13, 2023 at 08:30:29AM -0800, Johnathan Mantey wrote:
> This reverts commit 3780bb29311eccb7a1c9641032a112eed237f7e3.
> 
> The cited commit introduced unwanted behavior.
> 
> The intent for the commit was to be able to detect carrier loss/gain
> for just the NIC connected to the BMC. The unwanted effect is a
> carrier loss for auxiliary paths also causes the BMC to lose
> carrier. The BMC never regains carrier despite the secondary NIC
> regaining a link.
> 
> This change, when merged, needs to be backported to stable kernels.
> 5.4-stable, 5.10-stable, 5.15-stable, 6.1-stable, 6.5-stable
> 
> Fixes: 3780bb29311e ("ncsi: Propagate carrier gain/loss events to the NCSI controller")
> CC: stable@...r.kernel.org
> Signed-off-by: Johnathan Mantey <johnathanx.mantey@...el.com>

Hi Jonathan,

thanks for addressing my feedback on v2.

So far as addressing a regression goes, this looks good to me.
But I do wonder what can be done about the issue that
the cited commit was intended to address: will this patch regress things
on that front?

...

Powered by blists - more mailing lists