netdev - Re: [RFC PATCHv3 net-next 06/10] docs: bridge: add VLAN doc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <794505c1-da3c-c52a-ece8-9629ab6f32db@blackwall.org>
Date: Mon, 13 Nov 2023 11:54:36 +0200
From: Nikolay Aleksandrov <razor@...ckwall.org>
To: Hangbin Liu <liuhangbin@...il.com>, netdev@...r.kernel.org
Cc: "David S . Miller" <davem@...emloft.net>, David Ahern
 <dsahern@...nel.org>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Ido Schimmel <idosch@...sch.org>, Roopa Prabhu <roopa@...dia.com>,
 Stephen Hemminger <stephen@...workplumber.org>,
 Florian Westphal <fw@...len.de>, Andrew Lunn <andrew@...n.ch>,
 Florian Fainelli <f.fainelli@...il.com>, Vladimir Oltean
 <olteanv@...il.com>, Jiri Pirko <jiri@...nulli.us>
Subject: Re: [RFC PATCHv3 net-next 06/10] docs: bridge: add VLAN doc

On 11/10/23 12:15, Hangbin Liu wrote:
> Add VLAN part for bridge document.
> 
> Signed-off-by: Hangbin Liu <liuhangbin@...il.com>
> ---
>   Documentation/networking/bridge.rst | 29 +++++++++++++++++++++++++++++
>   1 file changed, 29 insertions(+)
> 
> diff --git a/Documentation/networking/bridge.rst b/Documentation/networking/bridge.rst
> index e168f86ddd82..88dfc6eb0919 100644
> --- a/Documentation/networking/bridge.rst
> +++ b/Documentation/networking/bridge.rst
> @@ -135,6 +135,35 @@ Proper configuration of STP parameters, such as the bridge priority, can
>   influence which bridge becomes the Root Bridge. Careful configuration can
>   optimize network performance and path selection.
>   
> +VLAN
> +====
> +
> +A LAN (Local Area Network) is a network that covers a small geographic area,
> +typically within a single building or a campus. LANs are used to connect
> +computers, servers, printers, and other networked devices within a localized
> +area. LANs can be wired (using Ethernet cables) or wireless (using Wi-Fi).
> +
> +A VLAN (Virtual Local Area Network) is a logical segmentation of a physical
> +network into multiple isolated broadcast domains. VLANs are used to divide
> +a single physical LAN into multiple virtual LANs, allowing different groups of
> +devices to communicate as if they were on separate physical networks.
> +
> +Typically there are two VLAN implementations, IEEE 802.1Q and IEEE 802.1ad
> +(also known as QinQ). IEEE 802.1Q is a standard for VLAN tagging in Ethernet
> +networks. It allows network administrators to create logical VLANs on a
> +physical network and tag Ethernet frames with VLAN information, which is
> +called *VLAN-tagged frames*. IEEE 802.1ad, commonly known as QinQ or Double
> +VLAN, is an extension of the IEEE 802.1Q standard. QinQ allows for the
> +stacking of multiple VLAN tags within a single Ethernet frame. The Linux
> +bridge supports both the IEEE 802.1Q and `802.1AD
> +<https://lore.kernel.org/netdev/1402401565-15423-1-git-send-email-makita.toshiaki@lab.ntt.co.jp/>`_
> +protocol for VLAN tagging.
> +
> +The `VLAN filtering <https://lore.kernel.org/netdev/1360792820-14116-1-git-send-email-vyasevic@redhat.com/>`_

drop "The", just VLAN filtering

> +on bridge is disabled by default. After enabling VLAN

on a bridge

> +filter on bridge, the bridge can handle VLAN-tagged frames and forward them

filtering on a bridge, it will

But here it sounds a bit misleading, as if vlan-tagged frames are not 
handled otherwise. They are, just vlan tags are not considered when
making forwarding decisions (e.g. FDB lookup).

> +to the appropriate destinations.
> +
>   FAQ
>   ===
>