[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20231113095744.GN705326@kernel.org>
Date: Mon, 13 Nov 2023 09:57:44 +0000
From: Simon Horman <horms@...nel.org>
To: Daniel Borkmann <daniel@...earbox.net>
Cc: martin.lau@...nel.org, kuba@...nel.org, razor@...ckwall.org,
sdf@...gle.com, netdev@...r.kernel.org, bpf@...r.kernel.org,
David Ahern <dsahern@...nel.org>
Subject: Re: [PATCH bpf v2 2/8] net: Move {l,t,d}stats allocation to core and
convert veth & vrf
On Sun, Nov 12, 2023 at 09:30:03PM +0100, Daniel Borkmann wrote:
> Move {l,t,d}stats allocation to the core and let netdevs pick the stats
> type they need. That way the driver doesn't have to bother with error
> handling (allocation failure checking, making sure free happens in the
> right spot, etc) - all happening in the core.
>
> Co-developed-by: Jakub Kicinski <kuba@...nel.org>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> Signed-off-by: Daniel Borkmann <daniel@...earbox.net>
> Cc: David Ahern <dsahern@...nel.org>
...
> @@ -2354,6 +2361,7 @@ struct net_device {
> void *ml_priv;
> enum netdev_ml_priv_type ml_priv_type;
>
> + enum netdev_stat_type pcpu_stat_type:8;
Hi Daniel,
nit: Please consider adding documentation for this new field to
the kernel doc for net_device.
...
Powered by blists - more mailing lists