netdev - Re: [PATCH v4 2/2] tg3: Increment tx_dropped in tg3_tso

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALs4sv1UCj_3Eafw6h=k5dbBqruBsVK04d985xdxi7+XodKC9Q@mail.gmail.com>
Date: Tue, 14 Nov 2023 15:36:19 +0530
From: Pavan Chebbi <pavan.chebbi@...adcom.com>
To: alexey.pakhunov@...cex.com
Cc: mchan@...adcom.com, vincent.wong2@...cex.com, netdev@...r.kernel.org, 
	linux-kernel@...r.kernel.org, siva.kallam@...adcom.com, prashant@...adcom.com
Subject: Re: [PATCH v4 2/2] tg3: Increment tx_dropped in tg3_tso_bug()

On Mon, Nov 13, 2023 at 11:54 PM <alexey.pakhunov@...cex.com> wrote:
>
> From: Alex Pakhunov <alexey.pakhunov@...cex.com>
>
> tg3_tso_bug() drops a packet if it cannot be segmented for any reason.
> The number of discarded frames should be incremented accordingly.
>
> Signed-off-by: Alex Pakhunov <alexey.pakhunov@...cex.com>
> Signed-off-by: Vincent Wong <vincent.wong2@...cex.com>
> ---
>  drivers/net/ethernet/broadcom/tg3.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c
> index dcaf97198ac2..8f22b4cdc31f 100644
> --- a/drivers/net/ethernet/broadcom/tg3.c
> +++ b/drivers/net/ethernet/broadcom/tg3.c
> @@ -7874,8 +7874,10 @@ static int tg3_tso_bug(struct tg3 *tp, struct tg3_napi *tnapi,
>
>         segs = skb_gso_segment(skb, tp->dev->features &
>                                     ~(NETIF_F_TSO | NETIF_F_TSO6));
> -       if (IS_ERR(segs) || !segs)
> +       if (IS_ERR(segs) || !segs) {
> +               tnapi->tx_dropped++;
>                 goto tg3_tso_bug_end;
> +       }
>
>         skb_list_walk_safe(segs, seg, next) {
>                 skb_mark_not_on_list(seg);
> --
> 2.39.3
>
>

Reviewed-by: Pavan Chebbi <pavan.chebbi@...adcom.com>
Thank you.

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4209 bytes)