netdev - Re: [PATCH v4 1/2] tg3: Move the [rt]x_dropped counters to tg3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACKFLin-hFa0HXN56fJ9U8+FNo4ngYmxMDnHikxr6Zgp377EGA@mail.gmail.com>
Date: Mon, 13 Nov 2023 15:19:57 -0800
From: Michael Chan <michael.chan@...adcom.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: mchan@...adcom.com, alexey.pakhunov@...cex.com, vincent.wong2@...cex.com, 
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org, 
	siva.kallam@...adcom.com, prashant@...adcom.com
Subject: Re: [PATCH v4 1/2] tg3: Move the [rt]x_dropped counters to tg3_napi

On Mon, Nov 13, 2023 at 2:38 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Mon, 13 Nov 2023 10:23:49 -0800 alexey.pakhunov@...cex.com wrote:
> > This change moves [rt]x_dropped counters to tg3_napi so that they can be
> > updated by a single writer, race-free.
>
> Michael, do you have a preference on the using u64_stats_inc() ?
> Since we're only doing inc here the conversion should be pretty
> trivial. The semantics of local64 are a bit murky but looks like
> other drivers think that it's okay to use inc without
> u64_stats_update_begin() / end().

The existing driver has been using unsigned long for these 2 software
counters, so I think it is ok to just keep them unchanged.  I agree
with Alexey that these 2 counters should be relatively rare.  We can
change to use u64_stats later if needed.

Thanks,
Reviewed-by: Michael Chan <michael.chan@...adcom.com>

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4209 bytes)