netdev - Re: [PATCH][net-next][v2] rtnetlink: instroduce vnlmsg_new and use it in rtnl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231114173757.0910964e@kernel.org>
Date: Tue, 14 Nov 2023 17:37:57 -0500
From: Jakub Kicinski <kuba@...nel.org>
To: Li RongQing <lirongqing@...du.com>
Cc: davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
 Liam.Howlett@...cle.com, anjali.k.kulkarni@...cle.com, leon@...nel.org,
 fw@...len.de, shayagr@...zon.com, idosch@...dia.com, razor@...ckwall.org,
 linyunsheng@...wei.com, netdev@...r.kernel.org
Subject: Re: [PATCH][net-next][v2] rtnetlink: instroduce vnlmsg_new and use
 it in rtnl_getlink

On Tue, 14 Nov 2023 17:55:22 +0800 Li RongQing wrote:
> -	nskb = nlmsg_new(if_nlmsg_size(dev, ext_filter_mask), GFP_KERNEL);
> +	nskb = vnlmsg_new(if_nlmsg_size(dev, ext_filter_mask));

Why vnlmsg_new()? nlmsg_ is a prefix, for netlink message.
prefixes do not combine like you're trying to make them.
Can you call it nlmsg_new_large() or similar?

>  	if (nskb == NULL)
>  		goto out;
>  
> diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c
> index eb086b0..17587f1 100644
> --- a/net/netlink/af_netlink.c
> +++ b/net/netlink/af_netlink.c
> @@ -1204,7 +1204,7 @@ struct sock *netlink_getsockbyfilp(struct file *filp)
>  	return sock;
>  }
>  
> -static struct sk_buff *netlink_alloc_large_skb(unsigned int size,
> +struct sk_buff *netlink_alloc_large_skb(unsigned int size,
>  					       int broadcast)

You need to fix the alignment of the continuation line.
Perhaps it now fits in 80chars so line break is not needed?