netdev - RE: [PATCH][net-next][v2] rtnetlink: instroduce vnlmsg_new and use it in rtnl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 15 Nov 2023 08:16:36 +0000
From: "Li,Rongqing" <lirongqing@...du.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: "davem@...emloft.net" <davem@...emloft.net>, "edumazet@...gle.com"
	<edumazet@...gle.com>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"Liam.Howlett@...cle.com" <Liam.Howlett@...cle.com>,
	"anjali.k.kulkarni@...cle.com" <anjali.k.kulkarni@...cle.com>,
	"leon@...nel.org" <leon@...nel.org>, "fw@...len.de" <fw@...len.de>,
	"shayagr@...zon.com" <shayagr@...zon.com>, "idosch@...dia.com"
	<idosch@...dia.com>, "razor@...ckwall.org" <razor@...ckwall.org>,
	"linyunsheng@...wei.com" <linyunsheng@...wei.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>
Subject: RE: [PATCH][net-next][v2] rtnetlink: instroduce vnlmsg_new and use it
 in rtnl_getlink



> -----Original Message-----
> From: Jakub Kicinski <kuba@...nel.org>
> Sent: Wednesday, November 15, 2023 6:38 AM
> To: Li,Rongqing <lirongqing@...du.com>
> Cc: davem@...emloft.net; edumazet@...gle.com; pabeni@...hat.com;
> Liam.Howlett@...cle.com; anjali.k.kulkarni@...cle.com; leon@...nel.org;
> fw@...len.de; shayagr@...zon.com; idosch@...dia.com;
> razor@...ckwall.org; linyunsheng@...wei.com; netdev@...r.kernel.org
> Subject: Re: [PATCH][net-next][v2] rtnetlink: instroduce vnlmsg_new and use it
> in rtnl_getlink
> 
> On Tue, 14 Nov 2023 17:55:22 +0800 Li RongQing wrote:
> > -	nskb = nlmsg_new(if_nlmsg_size(dev, ext_filter_mask), GFP_KERNEL);
> > +	nskb = vnlmsg_new(if_nlmsg_size(dev, ext_filter_mask));
> 
> Why vnlmsg_new()? nlmsg_ is a prefix, for netlink message.
> prefixes do not combine like you're trying to make them.
> Can you call it nlmsg_new_large() or similar?

I will rename it as nlmsg_new_large


> 
> >  	if (nskb == NULL)
> 
> You need to fix the alignment of the continuation line.
> Perhaps it now fits in 80chars so line break is not needed?

Line break is not needed,

Thanks

-Li