netdev - Re: [patch net-next 6/8] genetlink: introduce helpers to do filtered multicast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c7651635-d823-4a4e-be46-9d20c87b3eeb@intel.com>
Date: Wed, 15 Nov 2023 12:20:33 -0800
From: Jacob Keller <jacob.e.keller@...el.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Jiri Pirko
	<jiri@...nulli.us>
CC: <netdev@...r.kernel.org>, <kuba@...nel.org>, <pabeni@...hat.com>,
	<davem@...emloft.net>, <edumazet@...gle.com>, <jhs@...atatu.com>,
	<johannes@...solutions.net>, <amritha.nambiar@...el.com>, <sdf@...gle.com>
Subject: Re: [patch net-next 6/8] genetlink: introduce helpers to do filtered
 multicast



On 11/15/2023 6:53 AM, Andy Shevchenko wrote:
> On Wed, Nov 15, 2023 at 03:17:22PM +0100, Jiri Pirko wrote:
>> +				 int (*filter)(struct sock *dsk,
>> +					       struct sk_buff *skb,
>> +					       void *data),
> 
> Since it occurs more than once, perhaps
> 
> typedef int (*genlmsg_filter_fn)(struct sock *, struct sk_buff *, void *);
> 
> ?
> 

I agree with having a typedef here.

Thanks,
Jake