netdev - Re: [patch net-next 8/8] devlink: extend multicast filtering by port index

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZVXAVnJQzOKXlUlO@nanopsycho>
Date: Thu, 16 Nov 2023 08:10:14 +0100
From: Jiri Pirko <jiri@...nulli.us>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: netdev@...r.kernel.org, kuba@...nel.org, pabeni@...hat.com,
	davem@...emloft.net, edumazet@...gle.com, jacob.e.keller@...el.com,
	jhs@...atatu.com, johannes@...solutions.net,
	amritha.nambiar@...el.com, sdf@...gle.com
Subject: Re: [patch net-next 8/8] devlink: extend multicast filtering by port
 index

Wed, Nov 15, 2023 at 04:08:46PM CET, andriy.shevchenko@...ux.intel.com wrote:
>On Wed, Nov 15, 2023 at 03:17:24PM +0100, Jiri Pirko wrote:
>> From: Jiri Pirko <jiri@...dia.com>
>> 
>> Expose the previously introduced notification multicast messages
>> filtering infrastructure and allow the user to select messages using
>> port index.
>
>...
>
>>  	struct {
>>  		__u32 bus_name_len;
>>  		__u32 dev_name_len;
>> +		__u32 port_index:1;
>
>>From this context is not clear why others are not bitfields.

Tell it to the generator :)


>
>>  	} _present;
>>  
>>  	char *bus_name;
>>  	char *dev_name;
>> +	__u32 port_index;
>
>-- 
>With Best Regards,
>Andy Shevchenko
>
>