netdev - Re: [PATCH iwl-next] i40e: Use correct buffer size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231115092123.GI74656@kernel.org>
Date: Wed, 15 Nov 2023 09:21:23 +0000
From: Simon Horman <horms@...nel.org>
To: Kunwu Chan <chentao@...inos.cn>
Cc: anthony.l.nguyen@...el.com, davem@...emloft.net, edumazet@...gle.com,
	intel-wired-lan@...ts.osuosl.org, jeffrey.t.kirsher@...el.com,
	jesse.brandeburg@...el.com, kuba@...nel.org, kunwu.chan@...mail.com,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	pabeni@...hat.com, shannon.nelson@....com
Subject: Re: [PATCH iwl-next] i40e: Use correct buffer size

On Wed, Nov 15, 2023 at 11:14:44AM +0800, Kunwu Chan wrote:
> The size of "i40e_dbg_command_buf" is 256, the size of "name"
> depends on "IFNAMSIZ", plus a null character and format size,
> the total size is more than 256, fix it.
> 
> Signed-off-by: Kunwu Chan <chentao@...inos.cn>
> Suggested-by: Simon Horman <horms@...nel.org>
> ---
>  drivers/net/ethernet/intel/i40e/i40e_debugfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks for the update.

There is no need to repost because of this, but in future please keep in
mind that revised patches should:

1. have a revision number, e.g. v2

   Subject [PATCH v2 iwl-next] ...

2. Have some of revision information below the scissors (---)

   v2
   - Updated size calculation to use IFNAMSIZ and izeof(i40e_dbg_command_buf)

3. Be a new thread, as opposed to a reply to an existing thread.

Link: https://docs.kernel.org/process/maintainer-netdev.html#changes-requested

The above notwithstanding, this patch looks good to me.

Reviewed-by: Simon Horman <horms@...nel.org>