netdev - Re: [RFC PATCHv3 net-next 06/10] docs: bridge: add VLAN doc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZVSOGvpkyEzCWH2Q@Laptop-X1>
Date: Wed, 15 Nov 2023 17:23:38 +0800
From: Hangbin Liu <liuhangbin@...il.com>
To: Nikolay Aleksandrov <razor@...ckwall.org>
Cc: netdev@...r.kernel.org, "David S . Miller" <davem@...emloft.net>,
	David Ahern <dsahern@...nel.org>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Ido Schimmel <idosch@...sch.org>, Roopa Prabhu <roopa@...dia.com>,
	Stephen Hemminger <stephen@...workplumber.org>,
	Florian Westphal <fw@...len.de>, Andrew Lunn <andrew@...n.ch>,
	Florian Fainelli <f.fainelli@...il.com>,
	Vladimir Oltean <olteanv@...il.com>, Jiri Pirko <jiri@...nulli.us>
Subject: Re: [RFC PATCHv3 net-next 06/10] docs: bridge: add VLAN doc

On Mon, Nov 13, 2023 at 11:54:36AM +0200, Nikolay Aleksandrov wrote:
> > +The `VLAN filtering <https://lore.kernel.org/netdev/1360792820-14116-1-git-send-email-vyasevic@redhat.com/>`_
> 
> drop "The", just VLAN filtering
> 
> > +on bridge is disabled by default. After enabling VLAN
> 
> on a bridge
> 
> > +filter on bridge, the bridge can handle VLAN-tagged frames and forward them
> 
> filtering on a bridge, it will
> 
> But here it sounds a bit misleading, as if vlan-tagged frames are not
> handled otherwise. They are, just vlan tags are not considered when
> making forwarding decisions (e.g. FDB lookup).

How about:

VLAN filtering on a bridge is disabled by default. After enabling VLAN filtering
on a bridge, it will start forwarding frames to appropriate destinations based
on their VLAN tag.

Thanks
Hangbin