[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2a9bb683-da73-47af-8800-f14a833e8ee4@linaro.org>
Date: Fri, 17 Nov 2023 11:40:04 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Jie Luo <quic_luoj@...cinc.com>, agross@...nel.org, andersson@...nel.org,
konrad.dybcio@...aro.org, davem@...emloft.net, edumazet@...gle.com,
kuba@...nel.org, pabeni@...hat.com, robh+dt@...nel.org,
krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org, andrew@...n.ch,
hkallweit1@...il.com, linux@...linux.org.uk, robert.marko@...tura.hr
Cc: linux-arm-msm@...r.kernel.org, netdev@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
quic_srichara@...cinc.com
Subject: Re: [PATCH 9/9] dt-bindings: net: ipq4019-mdio: Document ipq5332
platform
On 17/11/2023 11:36, Jie Luo wrote:
>>> clocks:
>>> - items:
>>> - - description: MDIO clock source frequency fixed to 100MHZ
>>> + minItems: 1
>>> + maxItems: 5
>>> + description:
>>
>> Doesn't this make all other variants with incorrect constraints?
>
> There are 5 clock items, the first one is the legacy MDIO clock, the
> other clocks are new added for ipq5332 platform, will describe it more
> clearly in the next patch set.
OTHER variants. Not this one.
>
>>
>>> + MDIO system clock frequency fixed to 100MHZ, and the GCC uniphy
>>> + clocks enabled for resetting ethernet PHY.
>>>
>>> clock-names:
>>> - items:
>>> - - const: gcc_mdio_ahb_clk
>>> + minItems: 1
>>> + maxItems: 5
>>> +
>>> + phy-reset-gpio:
>>
>> No, for multiple reasons. It's gpios first of all. Where do you see such
>> property? Where is the existing definition?
>
> will remove this property, and update to use the exited PHY GPIO reset.
>
>>
>> Then it is "reset-gpios" if this is MDIO. Why do you put phy properties
>> in MDIO?
>>
>>> + minItems: 1
>>> + maxItems: 3
>>> + description:
>>> + GPIO used to reset the PHY, each GPIO is for resetting the connected
>>> + ethernet PHY device.
>>> +
>>> + phyaddr-fixup:
>>> + description: Register address for programing MDIO address of PHY devices
>>
>> You did not test code which you sent.
>
> Hi Krzysztof,
> This patch is passed with the following command in my workspace.
> i will upgrade and install yamllint to make sure there is no
> warning reported anymore.
>
> make dt_bg_check
No clue what's this, but no, I do not believe you tested it at all. It's
not about yamllint. It's was not tested. Look at errors reported on
mailing list.
> DT_SCHEMA_FILES=Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml
Best regards,
Krzysztof
Powered by blists - more mailing lists