netdev - Re: [PATCH net-next 9/9] net: pse-pd: Add PD692x0 PSE controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 17 Nov 2023 15:50:05 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Köry Maincent <kory.maincent@...tlin.com>
Cc: "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Jonathan Corbet <corbet@....net>,
	Luis Chamberlain <mcgrof@...nel.org>,
	Russ Weight <russ.weight@...ux.dev>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"Rafael J. Wysocki" <rafael@...nel.org>,
	Rob Herring <robh+dt@...nel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-doc@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH net-next 9/9] net: pse-pd: Add PD692x0 PSE controller
 driver

On Fri, Nov 17, 2023 at 12:22:36PM +0100, Köry Maincent wrote:
> Thanks for your review!
> 
> On Thu, 16 Nov 2023 23:41:55 +0100
> Andrew Lunn <andrew@...n.ch> wrote:
> 
> > > +struct pd692x0_msg {
> > > +	struct pd692x0_msg_content content;
> > > +	u16 delay_recv;
> > > +};  
> > 
> > > +	if (msg->delay_recv)
> > > +		msleep(msg->delay_recv);
> > > +	else
> > > +		msleep(30);  
> > 
> > > +	if (msg->delay_recv)
> > > +		msleep(msg->delay_recv);
> > > +	else
> > > +		msleep(30);  
> > 
> > > +	if (msg->delay_recv)
> > > +		msleep(msg->delay_recv);
> > > +	else
> > > +		msleep(30);
> > > +  
> > 
> > As far as i can see with a quick search, nothing ever sets delay_recv?
> > 
> > 	Andrew
> 
> In fact I wrote the driver taking into account that there are two commands (save
> and restore) that need a different delay response. As currently we do not
> support them I can indeed drop it for now and add it back when I will add their
> support.

When you add it back, maybe just arrange for delay_recv to be set to
30?

	Andrew