lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <ZVjest6pUoM2b9mO@oden.dyn.berto.se> Date: Sat, 18 Nov 2023 16:56:34 +0100 From: Niklas Söderlund <niklas.soderlund+renesas@...natech.se> To: Geert Uytterhoeven <geert@...ux-m68k.org> Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Richard Cochran <richardcochran@...il.com>, netdev@...r.kernel.org, linux-renesas-soc@...r.kernel.org Subject: Re: [net-next 4/5] net: ethernet: renesas: rcar_gen4_ptp: Add V4H clock setting Hi Geert, Thanks for your review. On 2023-11-18 12:16:51 +0100, Geert Uytterhoeven wrote: > Hi Niklas, > > On Fri, Nov 17, 2023 at 5:45 PM Niklas Söderlund > <niklas.soderlund+renesas@...natech.se> wrote: > > The gPTP clock is different between R-Car S4 and R-Car V4H. In > > preparation of adding R-Car V4H support define the clock setting. > > > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@...natech.se> > > Thanks for your patch! > > > --- a/drivers/net/ethernet/renesas/rcar_gen4_ptp.h > > +++ b/drivers/net/ethernet/renesas/rcar_gen4_ptp.h > > @@ -9,8 +9,12 @@ > > > > #include <linux/ptp_clock_kernel.h> > > > > -#define PTPTIVC_INIT 0x19000000 /* 320MHz */ > > -#define RCAR_GEN4_PTP_CLOCK_S4 PTPTIVC_INIT > > +#define PTPTIVC_INIT_200MHZ 0x28000000 /* 200MHz */ > > +#define PTPTIVC_INIT_320MHZ 0x19000000 /* 320MHz */ > > + > > +#define RCAR_GEN4_PTP_CLOCK_S4 PTPTIVC_INIT_320MHZ > > +#define RCAR_GEN4_PTP_CLOCK_V4H PTPTIVC_INIT_200MHZ > > I think the gPTP Timer Increment Value Configuration value should be > calculated from the module clock rate instead (rsw2 runs at 320 MHz > on R-Car S4, S0D4_HSC and tsn run at 200 MHz on R-Car V4H). This is a great idea, I will do so for v2. > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds -- Kind Regards, Niklas Söderlund
Powered by blists - more mailing lists