lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <ZVjfClFyO736qheC@oden.dyn.berto.se> Date: Sat, 18 Nov 2023 16:58:02 +0100 From: Niklas Söderlund <niklas.soderlund+renesas@...natech.se> To: Geert Uytterhoeven <geert@...ux-m68k.org> Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Richard Cochran <richardcochran@...il.com>, netdev@...r.kernel.org, linux-renesas-soc@...r.kernel.org Subject: Re: [net-next 5/5] net: ethernet: renesas: rcar_gen4_ptp: Break out to module Hi Geert, Thanks for your review. On 2023-11-18 12:20:41 +0100, Geert Uytterhoeven wrote: > Hi Niklas, > > Thanks for your patch! > > On Fri, Nov 17, 2023 at 5:45 PM Niklas Söderlund > <niklas.soderlund+renesas@...natech.se> wrote: > > The Gen3 gPTP support will be shared between the existing Renesas > > Gen4 > > > Ethernet Switch driver and the upcoming Renesas Ethernet-TSN driver. In > > preparation for this break out the gPTP support to its own module. > > > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@...natech.se> > > > --- a/drivers/net/ethernet/renesas/Kconfig > > +++ b/drivers/net/ethernet/renesas/Kconfig > > @@ -44,7 +44,17 @@ config RENESAS_ETHER_SWITCH > > select CRC32 > > select MII > > select PHYLINK > > + select RENESAS_GEN4_PTP > > help > > Renesas Ethernet Switch device driver. > > > > +config RENESAS_GEN4_PTP > > + tristate "Renesas R-Car Gen4 gPTP support" > > + depends on ARCH_RENESAS || COMPILE_TEST > > Perhaps > > tristate "Renesas R-Car Gen4 gPTP support" if COMPILE_TEST > > ? > > The driver is already auto-selected when needed. Good idea, will do for v2. > > > + select CRC32 > > + select MII > > + select PHYLIB > > + help > > + Renesas R-Car Gen4 gPTP device driver. > > + > > endif # NET_VENDOR_RENESAS > > > --- a/drivers/net/ethernet/renesas/rcar_gen4_ptp.c > > +++ b/drivers/net/ethernet/renesas/rcar_gen4_ptp.c > > > @@ -186,3 +188,6 @@ struct rcar_gen4_ptp_private *rcar_gen4_ptp_alloc(struct platform_device *pdev) > > > > return ptp; > > } > > +EXPORT_SYMBOL_GPL(rcar_gen4_ptp_alloc); > > + > > +MODULE_LICENSE("GPL"); > > Please add the other MODULE_*() definitions,too. Wops, checkpatch only complained about MODULE_LICENSE, will fix for v2. > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds -- Kind Regards, Niklas Söderlund
Powered by blists - more mailing lists