netdev - Re: [PATCH net-next v2] net: hsr: Add support for MC filtering at the slave device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231121135551.GB269041@kernel.org>
Date: Tue, 21 Nov 2023 13:55:51 +0000
From: Simon Horman <horms@...nel.org>
To: Ravi Gunasekaran <r-gunasekaran@...com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, wojciech.drewek@...el.com, bigeasy@...utronix.de,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org, srk@...com
Subject: Re: [PATCH net-next v2] net: hsr: Add support for MC filtering at
 the slave device

On Tue, Nov 21, 2023 at 11:07:53AM +0530, Ravi Gunasekaran wrote:
> From: Murali Karicheri <m-karicheri2@...com>
> 
> When MC (multicast) list is updated by the networking layer due to a
> user command and as well as when allmulti flag is set, it needs to be
> passed to the enslaved Ethernet devices. This patch allows this
> to happen by implementing ndo_change_rx_flags() and ndo_set_rx_mode()
> API calls that in turns pass it to the slave devices using
> existing API calls.
> 
> Signed-off-by: Murali Karicheri <m-karicheri2@...com>
> Signed-off-by: Ravi Gunasekaran <r-gunasekaran@...com>
> Reviewed-by: Wojciech Drewek <wojciech.drewek@...el.com>
> ---
> Changes since v1:
> * Renamed "hsr_ndo_set_rx_mode" to "hsr_set_rx_mode" based on Wojciech's comment
> * Picked up Wojciech's Reviewed-by tag from v1
> * Rebased to tip of linux-next
> 
> v1: https://lore.kernel.org/netdev/20231120110105.18416-1-r-gunasekaran@ti.com/

Thanks Ravi,

I confirm that the review of v1 has been addressed.
This patch looks good to me.

Reviewed-by: Simon Horman <horms@...nel.org>