lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 21 Nov 2023 14:59:11 +0100
From: Andrew Lunn <>
To: Yanteng Si <>
Subject: Re: [PATCH v5 2/9] net: stmmac: Allow platforms to set irq_flags

On Tue, Nov 21, 2023 at 08:01:53PM +0800, Yanteng Si wrote:
> 在 2023/11/12 03:51, Andrew Lunn 写道:
> > On Fri, Nov 10, 2023 at 05:25:41PM +0800, Yanteng Si wrote:
> > > Some platforms need extra irq flags when request multi msi, add
> > > irq_flags variable for them.
> > It would be nice to document what flags are needed.
> > 
> > You also seem to be pass the same flags to all instances of
> > request_irq. However, the flags should be specific to one irq.  So you
> > need irq_irq_flags, wol_irq_flags, lpi_irq_flags, etc.
> It is a trigger type.

Yes, i figure that out eventually. But it would be good to state it

And trigger type, edge verses level, rising vs falling, is a per
interrupt property. So you do need the flag per interrupt.


Powered by blists - more mailing lists