netdev - Re: [PATCH net] bpf: test_run: fix WARNING in format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4f832b6f-97b1-45b1-a210-b497ee6e55d5@linux.dev>
Date: Tue, 21 Nov 2023 21:28:29 -0800
From: Yonghong Song <yonghong.song@...ux.dev>
To: Edward Adam Davis <eadavis@...com>,
 syzbot+e2c932aec5c8a6e1d31c@...kaller.appspotmail.com
Cc: andrii@...nel.org, ast@...nel.org, bpf@...r.kernel.org,
 daniel@...earbox.net, davem@...emloft.net, edumazet@...gle.com,
 haoluo@...gle.com, hawk@...nel.org, john.fastabend@...il.com,
 jolsa@...nel.org, kpsingh@...nel.org, kuba@...nel.org,
 linux-kernel@...r.kernel.org, linux-trace-kernel@...r.kernel.org,
 martin.lau@...nel.org, martin.lau@...ux.dev, mhiramat@...nel.org,
 netdev@...r.kernel.org, pabeni@...hat.com, rostedt@...dmis.org,
 sdf@...gle.com, song@...nel.org, syzkaller-bugs@...glegroups.com, yhs@...com
Subject: Re: [PATCH net] bpf: test_run: fix WARNING in format_decode


On 11/21/23 7:50 PM, Edward Adam Davis wrote:
> Confirm that skb->len is not 0 to ensure that skb length is valid.
>
> Fixes: 114039b34201 ("bpf: Move skb->len == 0 checks into __bpf_redirect")
> Reported-by: syzbot+e2c932aec5c8a6e1d31c@...kaller.appspotmail.com
> Signed-off-by: Edward Adam Davis <eadavis@...com>

Stan, Could you take a look at this patch?


> ---
>   net/bpf/test_run.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/net/bpf/test_run.c b/net/bpf/test_run.c
> index c9fdcc5cdce1..78258a822a5c 100644
> --- a/net/bpf/test_run.c
> +++ b/net/bpf/test_run.c
> @@ -845,6 +845,9 @@ static int convert___skb_to_skb(struct sk_buff *skb, struct __sk_buff *__skb)
>   {
>   	struct qdisc_skb_cb *cb = (struct qdisc_skb_cb *)skb->cb;
>   
> +	if (!skb->len)
> +		return -EINVAL;
> +
>   	if (!__skb)
>   		return 0;
>