netdev - RE: [PATCH net v2 1/3] net: rswitch: Fix type of ret in rswitch_start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <TYBPR01MB534110E3B5BF79130F67D932D8BAA@TYBPR01MB5341.jpnprd01.prod.outlook.com>
Date: Wed, 22 Nov 2023 03:15:47 +0000
From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
To: Andrew Lunn <andrew@...n.ch>
CC: "s.shtylyov@....ru" <s.shtylyov@....ru>, "davem@...emloft.net"
	<davem@...emloft.net>, "edumazet@...gle.com" <edumazet@...gle.com>,
	"kuba@...nel.org" <kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-renesas-soc@...r.kernel.org" <linux-renesas-soc@...r.kernel.org>
Subject: RE: [PATCH net v2 1/3] net: rswitch: Fix type of ret in
 rswitch_start_xmit()

Hello,

> From: Andrew Lunn, Sent: Wednesday, November 22, 2023 12:10 PM
> 
> On Wed, Nov 22, 2023 at 10:25:54AM +0900, Yoshihiro Shimoda wrote:
> > The type of ret in rswitch_start_xmit() should be netdev_tx_t. So,
> > fix it.
> >
> > Fixes: 3590918b5d07 ("net: ethernet: renesas: Add support for "Ethernet Switch"")
> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
> > ---
> >  drivers/net/ethernet/renesas/rswitch.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/ethernet/renesas/rswitch.c b/drivers/net/ethernet/renesas/rswitch.c
> > index 43a7795d6591..abaaa1112588 100644
> > --- a/drivers/net/ethernet/renesas/rswitch.c
> > +++ b/drivers/net/ethernet/renesas/rswitch.c
> > @@ -1505,7 +1505,7 @@ static netdev_tx_t rswitch_start_xmit(struct sk_buff *skb, struct net_device *nd
> >  	struct rswitch_device *rdev = netdev_priv(ndev);
> >  	struct rswitch_gwca_queue *gq = rdev->tx_queue;
> >  	struct rswitch_ext_desc *desc;
> > -	int ret = NETDEV_TX_OK;
> > +	netdev_tx_t ret = NETDEV_TX_OK;
> >  	dma_addr_t dma_addr;
> 
> To keep with reverse christmas tree, ret needs moving up a bit.

Thank you for your review! I'll fix it on v3.

Best regards,
Yoshihiro Shimoda

>    Andrew