netdev - Re: [patch net-next v3 5/9] genetlink: implement release callback and free sk_user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZV7zG63ukL8JYGve@nanopsycho>
Date: Thu, 23 Nov 2023 07:37:15 +0100
From: Jiri Pirko <jiri@...nulli.us>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, pabeni@...hat.com, davem@...emloft.net,
	edumazet@...gle.com, jacob.e.keller@...el.com, jhs@...atatu.com,
	johannes@...solutions.net, andriy.shevchenko@...ux.intel.com,
	amritha.nambiar@...el.com, sdf@...gle.com, horms@...nel.org
Subject: Re: [patch net-next v3 5/9] genetlink: implement release callback
 and free sk_user_data there

Wed, Nov 22, 2023 at 08:50:55PM CET, kuba@...nel.org wrote:
>On Wed, 22 Nov 2023 19:20:58 +0100 Jiri Pirko wrote:
>> >I'm pretty sure I complained when it was being added. Long story.
>> >AFAIU user as in if the socket is opened by a kernel module, the kernel
>> >module is the user. There's no need to use this field for the
>> >implementation since the implementation can simply extend its 
>> >own structure to add a properly typed field.  
>> 
>> Okay, excuse me, as always I'm slow here. What structure are
>> you refering to?
>
>struct netlink_sock. Technically it may be a little cleaner to wrap 
>that in another struct that will be genetlink specific. But that's
>a larger surgery for relatively little benefit at this stage.

Got it. Will explore that path. Thanks!