lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <8d82761e-c978-4763-a765-f6e0b57ec6a6@loongson.cn> Date: Fri, 24 Nov 2023 21:14:19 +0800 From: Yanteng Si <siyanteng@...ngson.cn> To: Andrew Lunn <andrew@...n.ch> Cc: hkallweit1@...il.com, peppe.cavallaro@...com, alexandre.torgue@...s.st.com, joabreu@...opsys.com, fancer.lancer@...il.com, Jose.Abreu@...opsys.com, chenhuacai@...ngson.cn, linux@...linux.org.uk, dongbiao@...ngson.cn, guyinggang@...ngson.cn, netdev@...r.kernel.org, loongarch@...ts.linux.dev, chris.chenfeiyang@...il.com Subject: Re: [PATCH v5 3/9] net: stmmac: Add Loongson DWGMAC definitions 在 2023/11/22 11:39, Andrew Lunn 写道: > On Tue, Nov 21, 2023 at 05:55:24PM +0800, Yanteng Si wrote: >> Hi Andrew, >> >> 在 2023/11/12 04:07, Andrew Lunn 写道: >>>> +#ifdef CONFIG_DWMAC_LOONGSON >>>> +#define DMA_INTR_ABNORMAL (DMA_INTR_ENA_AIE_LOONGSON | DMA_INTR_ENA_AIE | \ >>>> + DMA_INTR_ENA_FBE | DMA_INTR_ENA_UNE) >>>> +#else >>>> #define DMA_INTR_ABNORMAL (DMA_INTR_ENA_AIE | DMA_INTR_ENA_FBE | \ >>>> DMA_INTR_ENA_UNE) >>>> +#endif >>> The aim is to produce one kernel which runs on all possible >>> variants. So we don't like to see this sort of #ifdef. Please try to >>> remove them. >> We now run into a tricky problem: we only have a few register >> definitions(DMA_XXX_LOONGSON) >> >> that are not the same as the dwmac1000 register definition. > What does DMA_INTR_ENA_AIE_LOONGSON do? This seems like an interrupt > mask, and this is enabling an interrupt source? However, i don't see > this bit being tested in any interrupt status register? Or is it > hiding in one of the other patches? In general, we split one into two. the details are as follows: DMA_INTR_ENA_NIE = DMA_INTR_ENA_NIE_LOONGSON= DMA_INTR_ENA_TX_NIE + DMA_INTR_ENA_RX_NIE DMA_INTR_ENA_AIE = DMA_INTR_ENA_AIE_LOONGSON= DMA_INTR_ENA_TX_AIE + DMA_INTR_ENA_RX_AIE DMA_STATUS_NIS = DMA_STATUS_TX_NIS_LOONGSON + DMA_STATUS_RX_NIS_LOONGSON DMA_STATUS_AIS = DMA_STATUS_TX_AIS_LOONGSON + DMA_STATUS_RX_AIS_LOONGSON DMA_STATUS_FBI = DMA_STATUS_TX_FBI_LOONGSON + DMA_STATUS_RX_FBI_LOONGSON > > This is where lots of small patches, with good descriptions helps. Ok, thanks for your advice, I will try to split it in the next version. Thanks, Yanteng > > Andrew
Powered by blists - more mailing lists