lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <ZWF-9DmwakJBonmf@google.com> Date: Fri, 24 Nov 2023 20:58:28 -0800 From: "dmitry.torokhov@...il.com" <dmitry.torokhov@...il.com> To: Alexey Makhalov <amakhalov@...are.com> Cc: Simon Horman <horms@...nel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "virtualization@...ts.linux.dev" <virtualization@...ts.linux.dev>, "H . Peter Anvin" <hpa@...or.com>, "x86@...nel.org" <x86@...nel.org>, "dave.hansen@...ux.intel.co" <dave.hansen@...ux.intel.co>, "bp@...en8.d" <bp@...en8.d>, Ingo Molnar <mingo@...hat.com>, Thomas Gleixner <tglx@...utronix.de>, Zack Rusin <zackr@...are.com>, Tim Merrifield <timothym@...are.com>, "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>, "daniel@...ll.ch" <daniel@...ll.ch>, "airlied@...il.com" <airlied@...il.com>, "tzimmermann@...e.de" <tzimmermann@...e.de>, "mripard@...nel.org" <mripard@...nel.org>, "maarten.lankhorst@...ux.intel.com" <maarten.lankhorst@...ux.intel.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "richardcochran@...il.com" <richardcochran@...il.com>, "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>, Linux-graphics-maintainer <Linux-graphics-maintainer@...are.com>, Pv-drivers <Pv-drivers@...are.com>, Nadav Amit <namit@...are.com>, Ajay Kaher <akaher@...are.com>, Jeff Sipek <jsipek@...are.com> Subject: Re: [PATCH 4/6] input/vmmouse: Use vmware_hypercall API On Sat, Nov 25, 2023 at 01:22:58AM +0000, Alexey Makhalov wrote: > On Nov 24, 2023, at 11:46 AM, Simon Horman <horms@...nel.org> wrote: > > > > On Wed, Nov 22, 2023 at 03:30:49PM -0800, Alexey Makhalov wrote: > >> Switch from VMWARE_HYPERCALL macro to vmware_hypercall API. > >> Eliminate arch specific code. No functional changes intended. > >> > >> Signed-off-by: Alexey Makhalov <amakhalov@...are.com> > > > > Hi Alexey, > > > > it is not strictly related to this patch, but I notice than an x86_64 > > allmodconfig build with W=1 using gcc-13 fails to compile this file. > > > > It appears that the problem relates to both priv->phys and > > psmouse->ps2dev.serio->phys being 32 bytes. > > > > > > drivers/input/mouse/vmmouse.c: In function ‘vmmouse_init’: > > drivers/input/mouse/vmmouse.c:455:53: error: ‘/input1’ directive output may be truncated writing 7 bytes into a region of size between 1 and 32 [-Werror=format-truncation=] > > 455 | snprintf(priv->phys, sizeof(priv->phys), "%s/input1", > > | ^~~~~~~ > > drivers/input/mouse/vmmouse.c:455:9: note: ‘snprintf’ output between 8 and 39 bytes into a destination of size 32 > > 455 | snprintf(priv->phys, sizeof(priv->phys), "%s/input1", > > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > 456 | psmouse->ps2dev.serio->phys); > > | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > > > ... > > Hi Simon, thanks for reporting the issue. > Zack, please take a look. We want the truncation behavior and we do not want GCC to make noise about these, that is why "format-truncation" is explicitly disabled for normal compiles. I guess we should exclude it even when we compile with W=1 instead of doing pointless changes in the drivers. Thanks. -- Dmitry
Powered by blists - more mailing lists