netdev - Re: [PATCH bpf-next v3 1/2] bpftool: mark orphaned programs during prog show

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACdoK4Jg_DffjRz72_Zsg3wCUs5eMAn+Jo61tMUVQvPNqM4pBw@mail.gmail.com>
Date: Mon, 27 Nov 2023 22:42:03 +0000
From: Quentin Monnet <quentin@...valent.com>
To: Stanislav Fomichev <sdf@...gle.com>
Cc: bpf@...r.kernel.org, ast@...nel.org, daniel@...earbox.net, 
	andrii@...nel.org, martin.lau@...ux.dev, song@...nel.org, yhs@...com, 
	john.fastabend@...il.com, kpsingh@...nel.org, haoluo@...gle.com, 
	jolsa@...nel.org, netdev@...r.kernel.org
Subject: Re: [PATCH bpf-next v3 1/2] bpftool: mark orphaned programs during
 prog show

On Mon, 27 Nov 2023 at 18:21, Stanislav Fomichev <sdf@...gle.com> wrote:
>
> Commit ef01f4e25c17 ("bpf: restore the ebpf program ID for BPF_AUDIT_UNLOAD
> and PERF_BPF_EVENT_PROG_UNLOAD") stopped removing program's id from
> idr when the offloaded/bound netdev goes away. I was supposed to
> take a look and check in [0], but apparently I did not.
>
> Martin points out it might be useful to keep it that way for
> observability sake, but we at least need to mark those programs as
> unusable.
>
> Mark those programs as 'orphaned' and keep printing the list when
> we encounter ENODEV.
>
> 0: unspec  tag 0000000000000000
>         xlated 0B  not jited  memlock 4096B  orphaned
>
> [0]: https://lore.kernel.org/all/CAKH8qBtyR20ZWAc11z1-6pGb3Hd47AQUTbE_cfoktG59TqaJ7Q@mail.gmail.com/
>
> v3:
> * use two spaces for "  orphaned" (Quentin)
>
> Cc: netdev@...r.kernel.org
> Fixes: ef01f4e25c17 ("bpf: restore the ebpf program ID for BPF_AUDIT_UNLOAD and PERF_BPF_EVENT_PROG_UNLOAD")
> Signed-off-by: Stanislav Fomichev <sdf@...gle.com>

Reviewed-by: Quentin Monnet <quentin@...valent.com>

Thanks!