netdev - Re: [PATCH net-next v4 02/13] net: page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 28 Nov 2023 15:47:02 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Shakeel Butt <shakeelb@...gle.com>, Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com, 
	hawk@...nel.org, ilias.apalodimas@...aro.org, dsahern@...il.com, 
	dtatulea@...dia.com, willemb@...gle.com, almasrymina@...gle.com
Subject: Re: [PATCH net-next v4 02/13] net: page_pool: id the page pools

On Mon, 2023-11-27 at 07:07 +0000, Shakeel Butt wrote:
> On Sun, Nov 26, 2023 at 03:07:29PM -0800, Jakub Kicinski wrote:
> > To give ourselves the flexibility of creating netlink commands
> > and ability to refer to page pool instances in uAPIs create
> > IDs for page pools.
> > 
> > Reviewed-by: Ilias Apalodimas <ilias.apalodimas@...aro.org>
> > Reviewed-by: Eric Dumazet <edumazet@...gle.com>
> > Acked-by: Jesper Dangaard Brouer <hawk@...nel.org>
> > Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> 
> Reviewed-by: Shakeel Butt <shakeelb@...gle.com>
> 
> [...]
> > +
> > +static DEFINE_XARRAY_FLAGS(page_pools, XA_FLAGS_ALLOC1);
> 
> One nit which you can totally ignore: you can use DEFINE_XARRAY_ALLOC1()
> above.

Since there is general agreement on the series in the current revision,
and the series is not small, I think it's better to apply it as-is. The
above could be addressed with a follow-up.

Cheers,

Paolo