lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20231130000259.GS1312390@ziepe.ca> Date: Wed, 29 Nov 2023 20:02:59 -0400 From: Jason Gunthorpe <jgg@...pe.ca> To: Pasha Tatashin <pasha.tatashin@...een.com> Cc: akpm@...ux-foundation.org, alex.williamson@...hat.com, alim.akhtar@...sung.com, alyssa@...enzweig.io, asahi@...ts.linux.dev, baolu.lu@...ux.intel.com, bhelgaas@...gle.com, cgroups@...r.kernel.org, corbet@....net, david@...hat.com, dwmw2@...radead.org, hannes@...xchg.org, heiko@...ech.de, iommu@...ts.linux.dev, jasowang@...hat.com, jernej.skrabec@...il.com, jonathanh@...dia.com, joro@...tes.org, kevin.tian@...el.com, krzysztof.kozlowski@...aro.org, kvm@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-doc@...r.kernel.org, linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org, linux-mm@...ck.org, linux-rockchip@...ts.infradead.org, linux-samsung-soc@...r.kernel.org, linux-sunxi@...ts.linux.dev, linux-tegra@...r.kernel.org, lizefan.x@...edance.com, marcan@...can.st, mhiramat@...nel.org, mst@...hat.com, m.szyprowski@...sung.com, netdev@...r.kernel.org, paulmck@...nel.org, rdunlap@...radead.org, robin.murphy@....com, samuel@...lland.org, suravee.suthikulpanit@....com, sven@...npeter.dev, thierry.reding@...il.com, tj@...nel.org, tomas.mudrunka@...il.com, vdumpa@...dia.com, virtualization@...ts.linux.dev, wens@...e.org, will@...nel.org, yu-cheng.yu@...el.com Subject: Re: [PATCH 09/16] iommu/iommufd: use page allocation function provided by iommu-pages.h On Wed, Nov 29, 2023 at 04:59:43PM -0500, Pasha Tatashin wrote: > On Tue, Nov 28, 2023 at 6:52 PM Jason Gunthorpe <jgg@...pe.ca> wrote: > > > > On Tue, Nov 28, 2023 at 08:49:31PM +0000, Pasha Tatashin wrote: > > > Convert iommu/iommufd/* files to use the new page allocation functions > > > provided in iommu-pages.h. > > > > > > Signed-off-by: Pasha Tatashin <pasha.tatashin@...een.com> > > > --- > > > drivers/iommu/iommufd/iova_bitmap.c | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > This is a short term allocation, it should not be counted, that is why > > it is already not using GFP_KERNEL_ACCOUNT. > > I made this change for completeness. I changed all calls to > get_free_page/alloc_page etc under driver/iommu to use the > iommu_alloc_* variants, this also helps future developers in this area > to use the right allocation functions. > The accounting is implemented using cheap per-cpu counters, so should > not affect the performance, I think it is OK to keep them here. Except it is a mis use of an API that should only be used for page table memory :( Jason
Powered by blists - more mailing lists